[GitHub] [camel] jamesnetherton commented on a diff in pull request #9014: CAMEL-18131 - Adding health check to test conectivity

[GitBox]

jamesnetherton commented on code in PR #9014:
URL: https://github.com/apache/camel/pull/9014#discussion_r1064333093


##########
components/camel-aws/camel-aws2-ses/src/main/java/org/apache/camel/component/aws2/ses/Ses2Endpoint.java:
##########
@@ -51,6 +56,15 @@ public void doStart() throws Exception {
         sesClient = configuration.getAmazonSESClient() != null
                 ? configuration.getAmazonSESClient()
                 : Ses2ClientFactory.getSesClient(configuration).getSesClient();
+
+        healthCheckRepository = 
HealthCheckHelper.getHealthCheckRepository(getCamelContext(),
+                ComponentsHealthCheckRepository.REPOSITORY_ID, 
ComponentsHealthCheckRepository.class);
+
+        if (healthCheckRepository != null) {
+            clientHealthCheck = new Ses2HealthCheck(this, getId());
+        }
+
+        healthCheckRepository.addHealthCheck(clientHealthCheck);

Review Comment:
   @rhuan080 - I think we should be adding the health check within the if 
statement that checks if `healthCheckRepository` is null.
   
   I fixed a similar case last week in 
https://github.com/apache/camel/pull/8994.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org