This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
The following commit(s) were added to refs/heads/main by this push: new 7dc1602d104 (chores) replace size() > 0 by !isEmpty() (#8929) 7dc1602d104 is described below commit 7dc1602d104eaec7ca7bc63f5b7fa804943c6ad9 Author: Gilvan Filho <gilvan.sfi...@gmail.com> AuthorDate: Tue Dec 20 02:37:29 2022 -0300 (chores) replace size() > 0 by !isEmpty() (#8929) * (chores) camel-aws-cloudtrail: replace size() > 0 by !isEmpty() * (chores) camel-aws-secrets-manager: replace size() > 0 by !isEmpty() * (chores) camel-exec: replace size() > 0 by !isEmpty() * (chores) camel-ftp: replace size() > 0 by !isEmpty() * (chores) camel-google-calendar: replace size() > 0 by !isEmpty() --- .../apache/camel/component/aws/cloudtrail/CloudtrailConsumer.java | 6 ++---- .../aws/secretsmanager/vault/CloudTrailReloadTriggerTask.java | 2 +- .../camel/component/exec/impl/DefaultExecCommandExecutor.java | 2 +- .../java/org/apache/camel/component/file/remote/SftpOperations.java | 2 +- .../component/google/calendar/BatchGoogleCalendarClientFactory.java | 2 +- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/components/camel-aws/camel-aws-cloudtrail/src/main/java/org/apache/camel/component/aws/cloudtrail/CloudtrailConsumer.java b/components/camel-aws/camel-aws-cloudtrail/src/main/java/org/apache/camel/component/aws/cloudtrail/CloudtrailConsumer.java index 282d382922f..9904cf6f79d 100644 --- a/components/camel-aws/camel-aws-cloudtrail/src/main/java/org/apache/camel/component/aws/cloudtrail/CloudtrailConsumer.java +++ b/components/camel-aws/camel-aws-cloudtrail/src/main/java/org/apache/camel/component/aws/cloudtrail/CloudtrailConsumer.java @@ -68,14 +68,12 @@ public class CloudtrailConsumer extends ScheduledBatchPollingConsumer { LookupEventsResponse response = getClient().lookupEvents(eventsRequestBuilder.build()); - if (response.events().size() > 0) { + if (!response.events().isEmpty()) { lastTime = response.events().get(0).eventTime(); } Queue<Exchange> exchanges = createExchanges(response.events()); - int processedExchangeCount = processBatch(CastUtils.cast(exchanges)); - - return processedExchangeCount; + return processBatch(CastUtils.cast(exchanges)); } @Override diff --git a/components/camel-aws/camel-aws-secrets-manager/src/main/java/org/apache/camel/component/aws/secretsmanager/vault/CloudTrailReloadTriggerTask.java b/components/camel-aws/camel-aws-secrets-manager/src/main/java/org/apache/camel/component/aws/secretsmanager/vault/CloudTrailReloadTriggerTask.java index d3a02ab3b4f..848d6bc9eaa 100644 --- a/components/camel-aws/camel-aws-secrets-manager/src/main/java/org/apache/camel/component/aws/secretsmanager/vault/CloudTrailReloadTriggerTask.java +++ b/components/camel-aws/camel-aws-secrets-manager/src/main/java/org/apache/camel/component/aws/secretsmanager/vault/CloudTrailReloadTriggerTask.java @@ -202,7 +202,7 @@ public class CloudTrailReloadTriggerTask extends ServiceSupport implements Camel LookupEventsResponse response = cloudTrailClient.lookupEvents(lookupEventsRequest); List<Event> events = response.events(); - if (events.size() > 0) { + if (!events.isEmpty()) { lastTime = events.get(0).eventTime(); } diff --git a/components/camel-exec/src/main/java/org/apache/camel/component/exec/impl/DefaultExecCommandExecutor.java b/components/camel-exec/src/main/java/org/apache/camel/component/exec/impl/DefaultExecCommandExecutor.java index dd50d7dfc2f..a12b5c6ca85 100644 --- a/components/camel-exec/src/main/java/org/apache/camel/component/exec/impl/DefaultExecCommandExecutor.java +++ b/components/camel-exec/src/main/java/org/apache/camel/component/exec/impl/DefaultExecCommandExecutor.java @@ -116,7 +116,7 @@ public class DefaultExecCommandExecutor implements ExecCommandExecutor { executor.setExitValues(null); Set<Integer> exitValues = execCommand.getExitValues(); - if (exitValues.size() > 0) { + if (!exitValues.isEmpty()) { executor.setExitValues(exitValues.stream().mapToInt(Integer::intValue).toArray()); } diff --git a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java index 3fde4ffcddb..974d6a3c592 100644 --- a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java +++ b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java @@ -1119,7 +1119,7 @@ public class SftpOperations implements RemoteFileOperations<SftpRemoteFile> { if (files == null) { return false; } - return files.size() >= 1; + return !files.isEmpty(); } catch (SftpException e) { // or an exception can be thrown with id 2 which means file does not // exists diff --git a/components/camel-google/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/BatchGoogleCalendarClientFactory.java b/components/camel-google/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/BatchGoogleCalendarClientFactory.java index 857c62d56d7..04a93eb5a82 100644 --- a/components/camel-google/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/BatchGoogleCalendarClientFactory.java +++ b/components/camel-google/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/BatchGoogleCalendarClientFactory.java @@ -124,7 +124,7 @@ public class BatchGoogleCalendarClientFactory implements GoogleCalendarClientFac .fromStream(ResourceHelper.resolveMandatoryResourceAsInputStream(camelContext, serviceAccountKey), transport, jsonFactory) - .createScoped(scopes != null && scopes.size() != 0 ? scopes : null).createDelegated(delegate); + .createScoped(scopes != null && !scopes.isEmpty() ? scopes : null).createDelegated(delegate); cred.refreshToken(); return cred; } catch (IOException e) {