christophd commented on code in PR #3870:
URL: https://github.com/apache/camel-k/pull/3870#discussion_r1037902135
##########
pkg/trait/service.go:
##########
@@ -61,6 +61,15 @@ func (t *serviceTrait) Configure(e *Environment) (bool,
error) {
return false, nil
}
+ // in case the knative-service and service trait are enabled, the
knative-service has priority
+ // then this service is disabled
+ if e.GetTrait(knativeServiceTraitID) != nil {
Review Comment:
This PR is only a short-term solution. In long-term we should refactor the
service traits and how they are configured and theirs dependency to each other.
The idea would be to configure all service traits with one single trait
config and have a new `service.type` trait config property that selects the
service nature (default vs. knative vs. any other)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
