lburgazzoli commented on code in PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#discussion_r1034732779
########## library/camel-kamelets-utils/src/main/java/org/apache/camel/kamelets/utils/format/converter/standard/JsonModelDataType.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel.kamelets.utils.format.converter.standard; + +import java.io.ByteArrayInputStream; +import java.io.InputStream; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.camel.CamelContext; +import org.apache.camel.CamelContextAware; +import org.apache.camel.CamelExecutionException; +import org.apache.camel.Exchange; +import org.apache.camel.InvalidPayloadException; +import org.apache.camel.component.jackson.JacksonDataFormat; +import org.apache.camel.kamelets.utils.format.spi.DataTypeConverter; +import org.apache.camel.kamelets.utils.format.spi.annotations.DataType; +import org.apache.camel.util.ObjectHelper; + +/** + * Data type converter able to unmarshal to given unmarshalType using jackson data format. + * <p/> + * Unmarshal type should be given as a fully qualified class name in the exchange properties. + */ +@DataType(name = "jsonObject", mediaType = "application/json") +public class JsonModelDataType implements DataTypeConverter, CamelContextAware { + + public static final String DATA_TYPE_MODEL_PROPERTY = "CamelDataTypeModel"; + + private CamelContext camelContext; + + private static final ObjectMapper mapper = new ObjectMapper(); + + @Override + public void convert(Exchange exchange) { + if (!exchange.hasProperties() || !exchange.getProperties().containsKey(DATA_TYPE_MODEL_PROPERTY)) { + return; + } + + ObjectHelper.notNull(camelContext, "camelContext"); + + String type = exchange.getProperty(DATA_TYPE_MODEL_PROPERTY, String.class); + try (JacksonDataFormat dataFormat = new JacksonDataFormat(mapper, camelContext.getClassResolver().resolveMandatoryClass(type))) { Review Comment: This seems quite heavy as you need to create a class from a string for each message IMHO, as a followup there should be a way to configure the converter properties i.e. in this case I think the type is likely to be a fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
