[GitHub] [camel] mrinalsharma commented on a diff in pull request #8749: Fixed Camel 18719 : camel-jbang - Adding the dependency of camel-quarkus-core creates two entries in exported POM.xml

[GitBox]

mrinalsharma commented on code in PR #8749:
URL: https://github.com/apache/camel/pull/8749#discussion_r1028403018


##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/common/RuntimeUtil.java:
##########
@@ -83,4 +83,20 @@ public static void loadProperties(Properties properties, 
File file) throws IOExc
         }
     }
 
+    public static String getDependencies(Properties properties) {
+        String deps = properties.getProperty("camel.jbang.dependencies");

Review Comment:
   My understanding is that properties are expected to be not null, if that's 
not the case we can see NullPointerException at so many other places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org