lburgazzoli commented on code in PR #1162: URL: https://github.com/apache/camel-kamelets/pull/1162#discussion_r1024896815
########## library/camel-kamelets-utils/src/main/java/org/apache/camel/kamelets/utils/format/converter/aws2/s3/AWS2S3JsonOutputType.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.camel.kamelets.utils.format.converter.aws2.s3; + +import java.io.IOException; +import java.nio.charset.StandardCharsets; + +import org.apache.camel.CamelExecutionException; +import org.apache.camel.Exchange; +import org.apache.camel.component.aws2.s3.AWS2S3Constants; +import org.apache.camel.kamelets.utils.format.spi.DataTypeConverter; +import org.apache.camel.kamelets.utils.format.spi.annotations.DataType; +import software.amazon.awssdk.core.ResponseInputStream; +import software.amazon.awssdk.utils.IoUtils; + +/** + * Json output data type represents file name as key and file content as Json structure. + * <p/> + * Example Json structure: { "key": "myFile.txt", "content": "Hello", } + */ +@DataType(scheme = "aws2-s3", name = "json") +public class AWS2S3JsonOutputType implements DataTypeConverter { + + private static final String TEMPLATE = "{" + + "\"key\": \"%s\", " + Review Comment: I think the main issue here is that we gonna have yet another envelope, which may be ok for sync kamelets but I would be careful using it on a source. I heard some similar discussion for i.e. debezium where the current payload is a little bit like this one but it make it things very complicated and users are often adding a transformation to unwrap the payload to be able to do further transformations. Food for thought -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
