mrinalsharma commented on PR #510:
URL: https://github.com/apache/camel-karavan/pull/510#issuecomment-1300516510

   > I moved `Download Image` button from main Designer view to Application and 
VSCode panel 
[87e5bcc](https://github.com/apache/camel-karavan/commit/87e5bccc5a3871722c7dab1fa35587589686b258)
   > 
   > Could you please put 'Download Image' functionality into downloadImage() 
function in KaravanDesigner.
   
   Why do you think this download code should be in KaravanDesigner. We want to 
print an image of route and the RouteDesigner has all the details needed to 
print. If we make a change in KaravanDesigner then from RouteDesigner we need 
to notify KaravanDesigner about height and width of the RouteDesigner area that 
needs to be printed. We would also have to filter out extra "classes" from a 
printable node that are not part ofRouteDesigner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to