jamesnetherton commented on code in PR #4093: URL: https://github.com/apache/camel-quarkus/pull/4093#discussion_r970889239
########## extensions/kubernetes/deployment/src/main/java/org/apache/camel/quarkus/component/kubernetes/cluster/deployment/KubernetesClusterServiceProcessor.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.kubernetes.cluster.deployment; + +import io.quarkus.deployment.annotations.BuildStep; +import io.quarkus.deployment.annotations.ExecutionTime; +import io.quarkus.deployment.annotations.Record; +import org.apache.camel.quarkus.component.kubernetes.cluster.KubernetesClusterServiceConfig; +import org.apache.camel.quarkus.component.kubernetes.cluster.KubernetesClusterServiceRecorder; +import org.apache.camel.quarkus.core.deployment.spi.RuntimeCamelContextCustomizerBuildItem; + +class KubernetesClusterServiceProcessor { + + @Record(value = ExecutionTime.RUNTIME_INIT) Review Comment: We could maybe move this to `STATIC_INIT`. Instead of a `CamelContextCustomizer`, we could produce a registry bean which `camel-main` will auto discover and add as a service on the `CamelContext`. WDYT? ########## extensions/kubernetes/runtime/src/main/java/org/apache/camel/quarkus/component/kubernetes/cluster/KubernetesClusterServiceConfig.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.kubernetes.cluster; + +import java.util.Map; +import java.util.Optional; +import java.util.function.BooleanSupplier; + +import io.quarkus.runtime.annotations.ConfigItem; +import io.quarkus.runtime.annotations.ConfigRoot; +import org.apache.camel.component.kubernetes.cluster.LeaseResourceType; +import org.eclipse.microprofile.config.ConfigProvider; + +@ConfigRoot(name = "camel.cluster.kubernetes") +public class KubernetesClusterServiceConfig { + + /** + * Whether a Kubernetes Cluster Service should be automatic configured + * according to 'quarkus.camel.cluster.kubernetes.*' configurations. + */ + @ConfigItem + public Optional<Boolean> enabled; + + /** + * The name of the lease resource used to do optimistic locking (defaults to + * 'leaders'). The resource name is used as prefix when the underlying + * Kubernetes resource can manage a single lock. + */ + @ConfigItem + public Optional<String> kubernetesResourceName; Review Comment: Nitpick - maybe just `resourceName`? The Kubernetes part could be implied by the config prefix (`camel.cluster.kubernetes`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
