[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4049: Springless JPA extension

[GitBox]

ppalaga commented on code in PR #4049:
URL: https://github.com/apache/camel-quarkus/pull/4049#discussion_r969257247


##########
integration-tests/jpa/src/main/java/org/apache/camel/quarkus/component/jpa/it/JpaRoute.java:
##########
@@ -73,7 +77,12 @@ public void configure() throws Exception {
         from("direct:idempotent")
                 .idempotentConsumer(
                         header("messageId"),
-                        jpaMessageIdRepository(entityManagerFactory, 
"idempotentProcessor"))
+                        new JpaMessageIdRepository(entityManagerFactory, new 
TransactionStrategy() {
+                            @Override
+                            public void executeInTransaction(Runnable 
runnable) {
+                                
QuarkusTransaction.run(runOptions().semantic(RunOptions.Semantic.JOIN_EXISTING),
 runnable);
+                            }
+                        }, "idempotentProcessor"))

Review Comment:
   Will end users always have to create the `JpaMessageIdRepository` like this? 
If so, can't we automate it for them somehow? Or at least document that they 
need to do this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org