essobedo commented on PR #3599: URL: https://github.com/apache/camel-k/pull/3599#issuecomment-1237082456
> LGTM. I'd make an additional effort to include an E2E test to make sure we won't break this feature in the future. Do you mean that E2E tests are also expected even for pure client-side features? I mean the operator is not involved and it only manipulates local files on the client side that is why I proposed only unit tests. I have a test that checks the behavior too https://github.com/apache/camel-k/pull/3599/files#diff-4e0df340b8c06d6aa9b35d150ac8f92bd3581782cbe423209151170311ccbc6dR120-R137, do you still prefer to have an additional E2E test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
