[GitHub] [camel-k] essobedo commented on a diff in pull request #3589: feat(cli): Add tail and tail-lines flags to the log command

[GitBox]

essobedo commented on code in PR #3589:
URL: https://github.com/apache/camel-k/pull/3589#discussion_r962597875


##########
pkg/cmd/log.go:
##########
@@ -46,6 +46,9 @@ func newCmdLog(rootCmdOptions *RootCmdOptions) 
(*cobra.Command, *logCmdOptions)
                RunE:    options.run,
        }
 
+       cmd.Flags().BoolP("tail", "f", false, "To show the end of the logs")
+       cmd.Flags().Int64P("tail-lines", "l", 10, "The number of lines from the 
end of the logs to show")

Review Comment:
   Good idea, let's use the same behavior as `kubectl logs`:
   ```
       --tail=-1:
        Lines of recent log file to display. Defaults to -1 with no selector, 
showing all log lines otherwise 10, if a
        selector is provided.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org