tadayosi commented on code in PR #3595:
URL: https://github.com/apache/camel-k/pull/3595#discussion_r961290354
##########
pkg/controller/kameletbinding/error_handler.go:
##########
@@ -46,11 +46,7 @@ func maybeErrorHandler(errHandlConf
*v1alpha1.ErrorHandlerSpec, bindingContext b
}
}
- err = setErrorHandlerConfiguration(errorHandlerBinding,
errorHandlerSpec)
- if err != nil {
- return nil, errors.Wrap(err, "could not set integration
error handler")
- }
-
+ setErrorHandlerConfiguration(errorHandlerBinding,
errorHandlerSpec)
Review Comment:
Should we really remove this error handling here? I see in this func it's
not needed as it's already validated above, but what if some one else found
`setErrorHandlerConfiguration()` useful and wanted to invoke it somewhere else?
I feel it's safe to keep this as is along with the
`setErrorHandlerConfiguration()` func.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
