oscerd commented on issue #1272: URL: https://github.com/apache/camel-kafka-connector/issues/1272#issuecomment-1205426372
No, it's not responsability of the component to support all the credentials provider. Why the component should bring another jar, if not used? The point is having the dependency in case of usage and you have all the possibility of adding it in the kamelet, in your POM, in your connector classpath, so no, definitely it's not responsability of the component. The component should support it and it is doing it. For the byte[] payload: the component should return an inputStream because it's a good way to pass data between different endpoint. Kafka is just one of the component and one of camel kafka connector is one of the runtime, we cannot change the payload just because a converter for kafka runtime doesn't exist. I would write a different converter and places it somewhere. It's not a big deal to add a dependency, but to me stating "it's responsibility of the component to support all the credentials provider" doesn't make sense. It must provide the feature, not making an uber-jar with all AWS SDKs just because potentially someone could use it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
