astefanutti commented on code in PR #3427:
URL: https://github.com/apache/camel-k/pull/3427#discussion_r937513707
##########
config/crd/bases/camel.apache.org_camelcatalogs.yaml:
##########
@@ -21,9 +21,6 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: camelcatalogs.camel.apache.org
Review Comment:
That should be reverted.
##########
helm/camel-k/crds/crd-integration-platform.yaml:
##########
@@ -21,9 +21,7 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: integrationplatforms.camel.apache.org
+ labels:n app: camel-k name: integrationplatforms.camel.apache.org
Review Comment:
That should be reverted.
##########
pkg/controller/build/build_controller.go:
##########
@@ -163,6 +163,14 @@ func (r *reconcileBuild) Reconcile(ctx context.Context,
request reconcile.Reques
newErrorRecoveryAction(),
newErrorAction(),
}
+ case v1.BuildStrategyMvnd:
+ actions = []Action{
+ newInitializeRoutineAction(),
+ newScheduleAction(r.reader),
+ newMonitorRoutineAction(),
+ newErrorRecoveryAction(),
+ newErrorAction(),
+ }
Review Comment:
That can be collapsed with the `v1.BuildStrategyRoutine` case above.
##########
config/crd/bases/camel.apache.org_integrationplatforms.yaml:
##########
@@ -21,9 +21,6 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: integrationplatforms.camel.apache.org
Review Comment:
That should be reverted.
##########
config/crd/bases/camel.apache.org_builds.yaml:
##########
@@ -21,9 +21,6 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: builds.camel.apache.org
Review Comment:
That should be reverted.
##########
helm/camel-k/crds/crd-build.yaml:
##########
@@ -21,9 +21,7 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: builds.camel.apache.org
+ labels:n app: camel-k name: builds.camel.apache.org
Review Comment:
That should be reverted.
##########
config/crd/bases/camel.apache.org_kamelets.yaml:
##########
@@ -21,9 +21,6 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: kamelets.camel.apache.org
Review Comment:
That should be reverted.
##########
config/crd/bases/camel.apache.org_integrationkits.yaml:
##########
@@ -21,9 +21,6 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: integrationkits.camel.apache.org
Review Comment:
That should be reverted.
##########
config/crd/bases/camel.apache.org_integrations.yaml:
##########
@@ -21,9 +21,6 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: integrations.camel.apache.org
Review Comment:
That should be reverted.
##########
helm/camel-k/crds/crd-integration.yaml:
##########
@@ -21,9 +21,7 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: integrations.camel.apache.org
+ labels:n app: camel-k name: integrations.camel.apache.org
Review Comment:
That should be reverted.
##########
config/crd/bases/camel.apache.org_kameletbindings.yaml:
##########
@@ -21,9 +21,6 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: kameletbindings.camel.apache.org
Review Comment:
That should be reverted.
##########
helm/camel-k/crds/crd-camel-catalog.yaml:
##########
@@ -21,9 +21,7 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: camelcatalogs.camel.apache.org
+ labels:n app: camel-k name: camelcatalogs.camel.apache.org
Review Comment:
That should be reverted.
##########
helm/camel-k/crds/crd-kamelet-binding.yaml:
##########
@@ -21,9 +21,7 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: kameletbindings.camel.apache.org
+ labels:n app: camel-k name: kameletbindings.camel.apache.org
Review Comment:
That should be reverted.
##########
helm/camel-k/crds/crd-integration-kit.yaml:
##########
@@ -21,9 +21,7 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: integrationkits.camel.apache.org
+ labels:n app: camel-k name: integrationkits.camel.apache.org
Review Comment:
That should be reverted.
##########
pkg/controller/build/build_controller.go:
##########
@@ -218,6 +226,14 @@ func (r *reconcileBuild) Reconcile(ctx context.Context,
request reconcile.Reques
return reconcile.Result{}, nil
}
+func newMonitorMvndAction() {
+ panic("unimplemented")
+}
+
+func newInitializeMvndAction() {
+ panic("unimplemented")
+}
+
Review Comment:
This can be removed.
##########
helm/camel-k/crds/crd-kamelet.yaml:
##########
@@ -21,9 +21,7 @@ metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.6.1
creationTimestamp: null
- labels:
- app: camel-k
- name: kamelets.camel.apache.org
+ labels:n app: camel-k name: kamelets.camel.apache.org
Review Comment:
That should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
