aldettinger commented on code in PR #3919:
URL: https://github.com/apache/camel-quarkus/pull/3919#discussion_r934248538


##########
integration-tests/google-pubsub/README.adoc:
##########
@@ -0,0 +1,21 @@
+== Google Pubsub integration tests
+
+=== Local container
+
+Google emulator differs a little bit from the real account.  For example there 
is a test which passes on local emulator but fails on real account (see an 
https://issues.apache.org/jira/browse/CAMEL-18277[issue] in Camel project).
+
+Tests are executed with local container, unless 
`GOOGLE_APPLICATION_CREDENTIALS` and `GOOGLE_PROJECT_ID` properties (both) are 
set.

Review Comment:
   Neat: avoiding parenthesis could make it much clearer ? Like `unless both A 
and B properties are set` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to