JiriOndrusek commented on code in PR #3847: URL: https://github.com/apache/camel-quarkus/pull/3847#discussion_r932112711
########## test-framework/junit5/src/main/java/org/apache/camel/quarkus/test/TestConfigSourceFactory.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.test; + +import java.util.Collections; +import java.util.HashMap; + +import io.smallrye.config.ConfigSourceContext; +import io.smallrye.config.ConfigSourceFactory; +import io.smallrye.config.common.MapBackedConfigSource; +import org.eclipse.microprofile.config.spi.ConfigSource; + +public class TestConfigSourceFactory implements ConfigSourceFactory { Review Comment: I'm sorry I overlooked the location of log configuration in `camel-test` module. My advice doesn't make sense, therefore the whole class as you suggested is pointless. (I thought that the camel-test-junit5 also defines default log configuration, therefore the class. Because it is not correct, the class shouldn't be part of the PR. It will be removed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
