JiriOndrusek commented on PR #3847: URL: https://github.com/apache/camel-quarkus/pull/3847#issuecomment-1191129352
New module `junit5-extension-tests` was added. This modue contains a test which covers continuous testing (also covers the use case when all camel component are in test scope)` I noticed that methods `afterAll`, `afterEach`, `afterTestExecution`, `beforeAll` and `beforeEach` are not executed (intentionally) and therefore I prepared methods `doAfterAll`, `doAfterConstruct`, `doAfterEach`, `doBeforeEach` and `doBeforeAll, which are called from quarkus callbacks (see https://quarkus.io/guides/getting-started-testing#enrichment-via-quarkustestcallback[documentation]). I also put a line into the doc describing the change. I put `final` to all not used methods (`afterAll`, `afterEach`, `afterTestExecution`, `beforeAll` and `beforeEach`). Now it is not possible to override this methods. (Without `final`, the code would seem correct but it wouldn't be executed.) @jamesnetherton, @zbendhiba what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
