christophd commented on code in PR #3382: URL: https://github.com/apache/camel-k/pull/3382#discussion_r908769732
########## config/rbac/operator-role-knative.yaml: ########## @@ -49,6 +51,8 @@ rules: - messaging.knative.dev resources: - subscriptions + - channels + - inmemorychannels Review Comment: yes, this is obsolete and you can remove that because it is already covered by the addressable-resolver cluster role provided by Knative itself. In the end Camel K just uses a cluster role binding in order to bind the operator service account to this addressable-resolver cluster role. This should give all read permissions to Knative resources such as brokers, channels, etc. Not sure about these create/delete permissions that you have also added in this PR for brokers and routes. Do we need that for some of the e2e tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
