aldettinger commented on PR #3847:
URL: https://github.com/apache/camel-quarkus/pull/3847#issuecomment-1164170050
@JiriOndrusek Thanks for investing time on this subject. It's great to see
that moving ahead step by step :+1:
Please find few raw comments below:
+ There is `excludeTestSyntheticBeanDuplicities` in
`InjectionPointProcesor`. Is it useful to run it when not testing ? Would there
be a way to do this step only in test mode ? if make sense
+ Is there a mix in the current test of the PR ? e.g.
AzureStorageBlobProcessor is modified
+ Naming is hard :) `test-framework/junit5`, if we implement pure
annotation based tests in the future, it might also be called junit5 ?
+ The PR suggest that `UseOverrideProperties` is finally working ?
+ Would we gain value by adding a test like
[RouteBuilderConfigureExceptionTest](https://github.com/apache/camel/blob/main/components/camel-test/camel-test-junit5/src/test/java/org/apache/camel/test/junit5/patterns/RouteBuilderConfigureExceptionTest.java)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
