tadayosi commented on PR #3372: URL: https://github.com/apache/camel-k/pull/3372#issuecomment-1164139792
@christophd > So my idea would be to merge this one first to make the scripts work on MacOS as it is right now and open a new issue to replace these switches with preferred gne-sed usage. WDYT? gnu sed should support `sed -i '' ...` notation so once you switch to gnu sed the scripts should already work as-is on macOS without the patch, so there's no need for merging it if I'm not mistaken. I thought what @squakez commented in the beginning > Altough this one fixes the problem, it introduces a maintenance burden as we're heavily duplicating code. means that if possible we'd want to remove the if-else switches altogether for better maintainability. Adding a section for macOS users in our developers guide to instruct the usage of gnu sed sounds an easy task compared to the gain we'd have in the scripts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
