tadayosi commented on code in PR #3373:
URL: https://github.com/apache/camel-k/pull/3373#discussion_r901370294
##########
e2e/knative/knative_test.go:
##########
@@ -118,6 +118,20 @@ func TestRunBroker(t *testing.T) {
})
}
+func TestRunCustomBroker(t *testing.T) {
Review Comment:
For E2E we prefer `t.Run(...)` over multiple `func Test...` test functions.
Isn't it something we can merge into a single `TestRunBroker(...)`?
Also it'd be great if we could take this opportunity to combine the existing
test functions into `TestRunBroker(...)` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
