robertonav20 commented on code in PR #3309:
URL: https://github.com/apache/camel-k/pull/3309#discussion_r885368082


##########
pkg/trait/builder.go:
##########
@@ -101,7 +102,14 @@ func (t *builderTrait) Apply(e *Environment) error {
                }})
 
        case v1.IntegrationPlatformBuildPublishStrategyBuildah:
+               var platform string
+               var found bool
+               if platform, found = 
e.Platform.Status.Build.PublishStrategyOptions[builder.BuildahPlatform]; !found 
{
+                       platform = platforms.DefaultSpec().OS + "/" + 
platforms.DefaultSpec().Architecture + "/" + platforms.DefaultSpec().Variant

Review Comment:
   I propose another solution... we can invert the logic in this way.
   
   The platform attribute will be initialized and mapped inside buildah if 
exists, otherwise platform will be ignored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to