squakez commented on code in PR #3185: URL: https://github.com/apache/camel-k/pull/3185#discussion_r869384193
########## examples/user-config/maven/README.md: ########## @@ -0,0 +1,17 @@ +# Camel K Maven configuration examples Review Comment: Good. Let's move it under /examples/maven. user-config directory was thought for `kamel run` parameters. ########## docs/modules/ROOT/partials/apis/camel-k-crds.adoc: ########## @@ -2301,6 +2301,13 @@ base Maven specification additional repositories +|`servers` + Review Comment: Where is this `servers` coming from? ########## docs/modules/ROOT/pages/configuration/maven.adoc: ########## @@ -1,18 +1,19 @@ = Configure Maven [[maven-settings]] -== Maven Settings +== Maven Settings and Maven Settings Security Review Comment: +1 for the documentation update. However, I'd have a separate section nested under `== Maven Settings` called `=== Security Settings`. In there you may link also to the Maven website which explain how to setup the security settings file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
