tadayosi commented on code in PR #3193:
URL: https://github.com/apache/camel-k/pull/3193#discussion_r849089290
##########
pkg/cmd/run.go:
##########
@@ -782,15 +788,15 @@ func resolvePodTemplate(ctx context.Context, cmd
*cobra.Command, templateSrc str
return err
}
-func uploadFileOrDirectory(platform *v1.IntegrationPlatform, item string,
integrationName string, cmd *cobra.Command, integration *v1.Integration) error {
+func uploadFileOrDirectory(platform *v1.IntegrationPlatform, item string,
integrationName string, cmd *cobra.Command, integration *v1.Integration,
verbose bool) error {
Review Comment:
Maybe we can change it into method of `runCmdOptions` as the args now looks
a bit too long.
##########
pkg/cmd/run.go:
##########
@@ -945,14 +955,16 @@ func extractGav(src *zip.File, localPath string)
(maven.Dependency, bool) {
}, true
}
-func uploadAsMavenArtifact(dependency maven.Dependency, path string, platform
*v1.IntegrationPlatform, ns string, options spectrum.Options) error {
+func uploadAsMavenArtifact(dependency maven.Dependency, path string, platform
*v1.IntegrationPlatform, ns string, options spectrum.Options, verbose bool)
error {
Review Comment:
Maybe we can change it into method of `runCmdOptions` as the args now looks
a bit too long.
##########
pkg/cmd/run.go:
##########
@@ -1028,15 +1040,19 @@ func writeChecksumToFile(filepath string, hash
hash.Hash) error {
return err
}
-func getSpectrumOptions(platform *v1.IntegrationPlatform, cmd *cobra.Command)
spectrum.Options {
+func getSpectrumOptions(platform *v1.IntegrationPlatform, cmd *cobra.Command,
verbose bool) spectrum.Options {
Review Comment:
Maybe we can change it into method of `runCmdOptions` as the args now looks
a bit too long.
##########
pkg/cmd/run.go:
##########
@@ -117,6 +117,7 @@ func newCmdRun(rootCmdOptions *RootCmdOptions)
(*cobra.Command, *runCmdOptions)
cmd.Flags().String("pod-template", "", "The path of the YAML file
containing a PodSpec template to be used for the Integration pods")
cmd.Flags().Bool("save", false, "Save the run parameters into the
default kamel configuration file (kamel-config.yaml)")
+ cmd.Flags().Bool("verbose", false, "Verbose logging")
Review Comment:
Is there no shorthand name for the flag? :smiley:
It looks like the `verbose` flag can be global, but maybe we can work on it
later?
##########
pkg/cmd/run.go:
##########
@@ -850,7 +860,7 @@ func getMountPath(targetPath string, dirName string, path
string) (string, error
}
// nolint:errcheck
-func uploadPomFromJar(gav maven.Dependency, path string, platform
*v1.IntegrationPlatform, ns string, options spectrum.Options) maven.Dependency {
+func uploadPomFromJar(gav maven.Dependency, path string, platform
*v1.IntegrationPlatform, ns string, options spectrum.Options, verbose bool)
maven.Dependency {
Review Comment:
Maybe we can change it into method of `runCmdOptions` as the args now looks
a bit too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
