This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 7dc30b5500026ede4ffcaa93ec7841e5f33106f8
Author: Otavio Rodolfo Piske <angusyo...@gmail.com>
AuthorDate: Tue Apr 12 18:17:54 2022 +0200
CAMEL-17763: cleaned up unused exceptions in camel-quickfix
---
.../component/quickfixj/QuickfixjComponentTest.java | 11 +++++------
.../component/quickfixj/QuickfixjEngineTest.java | 4 ++--
.../quickfixj/examples/AuthenticationExample.java | 2 +-
.../quickfixj/examples/RestartRouteExample.java | 2 +-
.../quickfixj/examples/trading/TradeExecutor.java | 19 ++++++++-----------
.../examples/trading/TradeExecutorComponent.java | 10 +++++-----
.../transform/QuickfixjEventJsonTransformer.java | 3 +--
.../transform/QuickfixjMessageJsonTransformer.java | 4 +---
8 files changed, 24 insertions(+), 31 deletions(-)
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjComponentTest.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjComponentTest.java
index 97659c45609..ceaa80eb2c5 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjComponentTest.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjComponentTest.java
@@ -20,7 +20,6 @@ import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.lang.reflect.Method;
-import java.net.MalformedURLException;
import java.net.URL;
import java.net.URLClassLoader;
import java.util.concurrent.CountDownLatch;
@@ -119,11 +118,11 @@ public class QuickfixjComponentTest {
Thread.currentThread().setContextClassLoader(testClassLoader);
}
- private void setUpComponent() throws IOException, MalformedURLException,
NoSuchMethodException {
+ private void setUpComponent() throws IOException, NoSuchMethodException {
setUpComponent(false);
}
- private void setUpComponent(boolean injectQfjPlugins) throws IOException,
MalformedURLException, NoSuchMethodException {
+ private void setUpComponent(boolean injectQfjPlugins) throws
NoSuchMethodException {
camelContext = new DefaultCamelContext();
component = new QuickfixjComponent();
component.setCamelContext(camelContext);
@@ -147,7 +146,7 @@ public class QuickfixjComponentTest {
}
@AfterEach
- public void tearDown() throws Exception {
+ public void tearDown() {
Thread.currentThread().setContextClassLoader(contextClassLoader);
if (component != null) {
component.stop();
@@ -335,7 +334,7 @@ public class QuickfixjComponentTest {
Consumer consumer = endpoint.createConsumer(new Processor() {
@Override
- public void process(Exchange exchange) throws Exception {
+ public void process(Exchange exchange) {
QuickfixjEventCategory eventCategory
= (QuickfixjEventCategory)
exchange.getIn().getHeader(QuickfixjEndpoint.EVENT_CATEGORY_KEY);
if (eventCategory == QuickfixjEventCategory.SessionCreated) {
@@ -394,7 +393,7 @@ public class QuickfixjComponentTest {
Consumer consumer = endpoint.createConsumer(new Processor() {
@Override
- public void process(Exchange exchange) throws Exception {
+ public void process(Exchange exchange) {
QuickfixjEventCategory eventCategory
= (QuickfixjEventCategory)
exchange.getIn().getHeader(QuickfixjEndpoint.EVENT_CATEGORY_KEY);
if (eventCategory == QuickfixjEventCategory.SessionLogon) {
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjEngineTest.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjEngineTest.java
index 460be6b79b2..e3c0db207db 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjEngineTest.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/QuickfixjEngineTest.java
@@ -112,7 +112,7 @@ public class QuickfixjEngineTest {
}
@AfterEach
- public void tearDown() throws Exception {
+ public void tearDown() {
Thread.currentThread().setContextClassLoader(contextClassLoader);
if (quickfixjEngine != null) {
quickfixjEngine.stop();
@@ -120,7 +120,7 @@ public class QuickfixjEngineTest {
}
@Test
- public void missingSettingsResource() throws Exception {
+ public void missingSettingsResource() {
assertThrows(FileNotFoundException.class,
() -> new QuickfixjEngine(camelContext, "quickfix:test",
"bogus.cfg"));
}
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/AuthenticationExample.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/AuthenticationExample.java
index bfb1f47b156..0ba181a813d 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/AuthenticationExample.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/AuthenticationExample.java
@@ -54,7 +54,7 @@ public class AuthenticationExample {
RouteBuilder routes = new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
// Modify the outgoing logon message to add a password
// The modified message will be sent from the FIX engine when
the message exchange completes
from("quickfix:examples/inprocess.cfg?sessionID=FIX.4.2:TRADER->MARKET").filter(PredicateBuilder.and(
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/RestartRouteExample.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/RestartRouteExample.java
index 62b6db0c270..84ca802e02f 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/RestartRouteExample.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/RestartRouteExample.java
@@ -49,7 +49,7 @@ public class RestartRouteExample {
RouteBuilder routes = new RouteBuilder() {
@Override
- public void configure() throws Exception {
+ public void configure() {
from("quickfix:examples/inprocess.cfg?sessionID=FIX.4.2:MARKET->TRADER").routeId("foo")
.filter(header(QuickfixjEndpoint.MESSAGE_TYPE_KEY).isEqualTo(MsgType.EMAIL))
.bean(new CountDownLatchDecrementer("message",
receivedMessageLatch));
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutor.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutor.java
index ae24095977a..0cefd2c2da0 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutor.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutor.java
@@ -26,10 +26,8 @@ import java.util.concurrent.CopyOnWriteArrayList;
import org.apache.camel.RuntimeCamelException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import quickfix.ConfigError;
import quickfix.DataDictionary;
import quickfix.DataDictionaryProvider;
-import quickfix.FieldConvertError;
import quickfix.FieldNotFound;
import quickfix.FixVersions;
import quickfix.IncorrectTagValue;
@@ -39,7 +37,6 @@ import quickfix.MessageUtils;
import quickfix.Session;
import quickfix.SessionID;
import quickfix.SessionNotFound;
-import quickfix.UnsupportedMessageType;
import quickfix.field.ApplVerID;
import quickfix.field.AvgPx;
import quickfix.field.CumQty;
@@ -73,7 +70,7 @@ public class TradeExecutor {
private int orderID;
private int execID;
- public TradeExecutor() throws ConfigError, FieldConvertError {
+ public TradeExecutor() {
setAlwaysFillLimitOrders(true);
Set<String> validOrderTypes = new HashSet<>();
@@ -108,7 +105,7 @@ public class TradeExecutor {
listeners.remove(listener);
}
- public void execute(final Message message) throws FieldNotFound,
UnsupportedMessageType, IncorrectTagValue {
+ public void execute(final Message message) {
final SessionID sessionID = MessageUtils.getSessionID(message);
try {
@@ -131,7 +128,7 @@ public class TradeExecutor {
}
private void onMessage(quickfix.fix40.NewOrderSingle order, SessionID
sessionID)
- throws FieldNotFound, UnsupportedMessageType, IncorrectTagValue {
+ throws FieldNotFound, IncorrectTagValue {
try {
validateOrder(order);
@@ -240,7 +237,7 @@ public class TradeExecutor {
}
private void onMessage(quickfix.fix41.NewOrderSingle order, SessionID
sessionID)
- throws FieldNotFound, UnsupportedMessageType, IncorrectTagValue {
+ throws FieldNotFound, IncorrectTagValue {
try {
validateOrder(order);
@@ -280,7 +277,7 @@ public class TradeExecutor {
}
private void onMessage(quickfix.fix42.NewOrderSingle order, SessionID
sessionID)
- throws FieldNotFound, UnsupportedMessageType, IncorrectTagValue {
+ throws FieldNotFound, IncorrectTagValue {
try {
validateOrder(order);
@@ -328,7 +325,7 @@ public class TradeExecutor {
}
private void onMessage(quickfix.fix43.NewOrderSingle order, SessionID
sessionID)
- throws FieldNotFound, UnsupportedMessageType, IncorrectTagValue {
+ throws FieldNotFound, IncorrectTagValue {
try {
validateOrder(order);
@@ -363,7 +360,7 @@ public class TradeExecutor {
}
private void onMessage(quickfix.fix44.NewOrderSingle order, SessionID
sessionID)
- throws FieldNotFound, UnsupportedMessageType, IncorrectTagValue {
+ throws FieldNotFound, IncorrectTagValue {
try {
validateOrder(order);
@@ -398,7 +395,7 @@ public class TradeExecutor {
}
private void onMessage(quickfix.fix50.NewOrderSingle order, SessionID
sessionID)
- throws FieldNotFound, UnsupportedMessageType, IncorrectTagValue {
+ throws FieldNotFound, IncorrectTagValue {
try {
validateOrder(order);
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutorComponent.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutorComponent.java
index 5b03354383c..c12b4e078e0 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutorComponent.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/trading/TradeExecutorComponent.java
@@ -126,10 +126,10 @@ public class TradeExecutorComponent extends
DefaultComponent {
}
@Override
- public Producer createProducer() throws Exception {
+ public Producer createProducer() {
return new DefaultProducer(this) {
@Override
- public void process(final Exchange exchange) throws Exception {
+ public void process(final Exchange exchange) {
executor.execute(new Runnable() {
@Override
public void run() {
@@ -145,15 +145,15 @@ public class TradeExecutorComponent extends
DefaultComponent {
}
@Override
- public Consumer createConsumer(Processor processor) throws Exception {
+ public Consumer createConsumer(Processor processor) {
return new DefaultConsumer(this, processor) {
@Override
- protected void doStart() throws Exception {
+ protected void doStart() {
processors.add(getProcessor());
}
@Override
- protected void doStop() throws Exception {
+ protected void doStop() {
processors.remove(getProcessor());
}
};
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjEventJsonTransformer.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjEventJsonTransformer.java
index 4c235ee059c..a78ebe86be3 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjEventJsonTransformer.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjEventJsonTransformer.java
@@ -18,7 +18,6 @@ package
org.apache.camel.component.quickfixj.examples.transform;
import org.apache.camel.Exchange;
import org.apache.camel.component.quickfixj.QuickfixjEndpoint;
-import quickfix.ConfigError;
import quickfix.DataDictionary;
import quickfix.Message;
import quickfix.Session;
@@ -27,7 +26,7 @@ import quickfix.SessionID;
public class QuickfixjEventJsonTransformer {
private final QuickfixjMessageJsonTransformer renderer;
- public QuickfixjEventJsonTransformer() throws ConfigError {
+ public QuickfixjEventJsonTransformer() {
renderer = new QuickfixjMessageJsonTransformer();
}
diff --git
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjMessageJsonTransformer.java
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjMessageJsonTransformer.java
index ba0820b2da9..4a0ee3aac3f 100644
---
a/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjMessageJsonTransformer.java
+++
b/components/camel-quickfix/src/test/java/org/apache/camel/component/quickfixj/examples/transform/QuickfixjMessageJsonTransformer.java
@@ -18,11 +18,9 @@ package
org.apache.camel.component.quickfixj.examples.transform;
import java.util.Iterator;
-import quickfix.ConfigError;
import quickfix.DataDictionary;
import quickfix.Field;
import quickfix.FieldMap;
-import quickfix.FieldNotFound;
import quickfix.FieldType;
import quickfix.Group;
import quickfix.Message;
@@ -32,7 +30,7 @@ import quickfix.SessionID;
public class QuickfixjMessageJsonTransformer {
- public String transform(Message message) throws FieldNotFound, ConfigError
{
+ public String transform(Message message) {
SessionID sessionID = MessageUtils.getSessionID(message);
Session session = Session.lookupSession(sessionID);
DataDictionary dataDictionary = session.getDataDictionary();
