This is an automated email from the ASF dual-hosted git repository. orpiske pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit 6c555f27ffdc91f218943b78955b80ce1395f2a9 Author: Otavio Rodolfo Piske <angusyo...@gmail.com> AuthorDate: Tue Apr 12 17:25:32 2022 +0200 CAMEL-17763: cleaned up unused exceptions in camel-mllp --- .../MllpTcpServerConsumerLenientBindTest.java | 2 +- .../apache/camel/component/mllp/LogPhiTest.java | 4 +- .../MllpAcknowledgementDeliveryExceptionTest.java | 12 ++--- .../mllp/MllpAcknowledgementExceptionTest.java | 18 +++---- .../MllpAcknowledgementReceiveExceptionTest.java | 24 +++------ .../MllpAcknowledgementTimeoutExceptionTest.java | 27 ++++------ ...plicationErrorAcknowledgementExceptionTest.java | 9 ++-- ...licationRejectAcknowledgementExceptionTest.java | 9 ++-- ...llpCommitErrorAcknowledgementExceptionTest.java | 9 ++-- ...lpCommitRejectAcknowledgementExceptionTest.java | 9 ++-- .../camel/component/mllp/MllpExceptionTest.java | 16 +++--- .../mllp/MllpIdleTimeoutStrategyTest.java | 4 +- .../MllpInvalidAcknowledgementExceptionTest.java | 6 +-- .../mllp/MllpInvalidMessageExceptionTest.java | 6 +-- .../mllp/MllpMaxConcurrentConsumersTest.java | 2 +- .../MllpNegativeAcknowledgementExceptionTest.java | 9 ++-- .../MllpProducerConsumerLoopbackInOnlyTest.java | 2 +- .../mllp/MllpProducerConsumerLoopbackTest.java | 4 +- .../component/mllp/MllpReceiveExceptionTest.java | 18 +++---- .../component/mllp/MllpSocketExceptionTest.java | 6 +-- .../MllpTcpClientProducerConnectionErrorTest.java | 2 +- ...TcpClientProducerIdleConnectionTimeoutTest.java | 2 +- .../component/mllp/MllpTcpServerCharsetTest.java | 2 +- .../mllp/MllpTcpServerConsumerBindTimeoutTest.java | 2 +- .../MllpTcpServerConsumerMessageHeadersTest.java | 2 +- ...MllpTcpServerConsumerMulitpleTcpPacketTest.java | 2 +- ...umerOptionalEndOfDataWithoutValidationTest.java | 2 +- .../mllp/MllpTcpServerConsumerTransactionTest.java | 4 +- .../component/mllp/MllpWriteExceptionTest.java | 12 ++--- ...tProducerEndOfDataAndValidationTestSupport.java | 29 ++++++----- ...cpServerConsumerAcknowledgementTestSupport.java | 2 +- ...rConsumerEndOfDataAndValidationTestSupport.java | 8 +-- .../camel/component/mllp/internal/Hl7UtilTest.java | 57 +++++++++------------- .../mllp/internal/MllpSocketBufferTest.java | 24 +++------ .../mllp/internal/MllpSocketBufferWriteTest.java | 39 +++++---------- .../camel/test/executor/PooledExecutorTest.java | 4 +- .../test/junit/rule/mllp/MllpClientResource.java | 10 ++-- .../test/junit/rule/mllp/MllpServerResource.java | 2 +- .../camel/test/mllp/PassthroughProcessor.java | 2 +- .../camel/test/stub/tcp/SocketInputStreamStub.java | 6 +-- .../org/apache/camel/test/stub/tcp/SocketStub.java | 16 +++--- 41 files changed, 167 insertions(+), 258 deletions(-) diff --git a/components/camel-mllp/src/test/java/org/apache/camel/MllpTcpServerConsumerLenientBindTest.java b/components/camel-mllp/src/test/java/org/apache/camel/MllpTcpServerConsumerLenientBindTest.java index 5e75b2843d2..cc727d1f0a5 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/MllpTcpServerConsumerLenientBindTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/MllpTcpServerConsumerLenientBindTest.java @@ -59,7 +59,7 @@ public class MllpTcpServerConsumerLenientBindTest extends CamelTestSupport { } @Override - protected RoutesBuilder createRouteBuilder() throws Exception { + protected RoutesBuilder createRouteBuilder() { RouteBuilder builder = new RouteBuilder() { String routeId = "mllp-receiver-with-lenient-bind"; diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/LogPhiTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/LogPhiTest.java index 841c9b606c3..cffb47e124e 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/LogPhiTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/LogPhiTest.java @@ -64,7 +64,7 @@ public class LogPhiTest extends CamelTestSupport { } @Override - protected RoutesBuilder createRouteBuilder() throws Exception { + protected RoutesBuilder createRouteBuilder() { return new RouteBuilder() { @Override @@ -113,7 +113,7 @@ public class LogPhiTest extends CamelTestSupport { testLogPhi(startDefaultPhi, exceptionMessage -> assertTrue(exceptionMessage.contains("hl7Message"))); } - public void testLogPhi(Endpoint endpoint, Consumer<String> contains) throws Exception { + public void testLogPhi(Endpoint endpoint, Consumer<String> contains) { Exchange exchange = endpoint.createExchange(InOut); String message = Hl7TestMessageGenerator.generateMessage(); exchange.getIn().setBody(message); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementDeliveryExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementDeliveryExceptionTest.java index 93a3e594f3f..b2e52bb0fee 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementDeliveryExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementDeliveryExceptionTest.java @@ -33,10 +33,9 @@ public class MllpAcknowledgementDeliveryExceptionTest extends MllpExceptionTestS /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpAcknowledgementDeliveryException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(TEST_EXCEPTION_MESSAGE)); @@ -47,10 +46,9 @@ public class MllpAcknowledgementDeliveryExceptionTest extends MllpExceptionTestS /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpAcknowledgementDeliveryException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); assertSame(CAUSE, instance.getCause()); @@ -62,10 +60,9 @@ public class MllpAcknowledgementDeliveryExceptionTest extends MllpExceptionTestS /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorThree() throws Exception { + public void testConstructorThree() { final String alternateExceptionMessage = "Alternate Message"; instance = new MllpAcknowledgementDeliveryException( @@ -79,10 +76,9 @@ public class MllpAcknowledgementDeliveryExceptionTest extends MllpExceptionTestS /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFour() throws Exception { + public void testConstructorFour() { final String alternateExceptionMessage = "Alternate Message"; instance = new MllpAcknowledgementDeliveryException( diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementExceptionTest.java index 566ec9dc6fd..12e4eaaf0ff 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementExceptionTest.java @@ -34,10 +34,9 @@ public class MllpAcknowledgementExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpAcknowledgementExceptionStub(TEST_EXCEPTION_MESSAGE, LOG_PHI_TRUE); assertNull(instance.getCause()); @@ -49,10 +48,9 @@ public class MllpAcknowledgementExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpAcknowledgementExceptionStub(TEST_EXCEPTION_MESSAGE, CAUSE, LOG_PHI_TRUE); assertSame(CAUSE, instance.getCause()); @@ -64,10 +62,9 @@ public class MllpAcknowledgementExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorThree() throws Exception { + public void testConstructorThree() { instance = new MllpAcknowledgementExceptionStub(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertNull(instance.getCause()); @@ -79,10 +76,9 @@ public class MllpAcknowledgementExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFour() throws Exception { + public void testConstructorFour() { instance = new MllpAcknowledgementExceptionStub( TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); @@ -95,10 +91,9 @@ public class MllpAcknowledgementExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFive() throws Exception { + public void testConstructorFive() { instance = new MllpAcknowledgementExceptionStub(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertSame(CAUSE, instance.getCause()); @@ -110,10 +105,9 @@ public class MllpAcknowledgementExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorSix() throws Exception { + public void testConstructorSix() { instance = new MllpAcknowledgementExceptionStub( TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementReceiveExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementReceiveExceptionTest.java index 4f3d6665530..76a9722ad06 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementReceiveExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementReceiveExceptionTest.java @@ -34,10 +34,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpAcknowledgementReceiveException(HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementReceiveException.EXCEPTION_MESSAGE)); @@ -49,10 +48,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpAcknowledgementReceiveException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementReceiveException.EXCEPTION_MESSAGE)); @@ -64,10 +62,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorThree() throws Exception { + public void testConstructorThree() { instance = new MllpAcknowledgementReceiveException(HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementReceiveException.EXCEPTION_MESSAGE)); @@ -79,10 +76,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFour() throws Exception { + public void testConstructorFour() { instance = new MllpAcknowledgementReceiveException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementReceiveException.EXCEPTION_MESSAGE)); @@ -94,10 +90,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFive() throws Exception { + public void testConstructorFive() { instance = new MllpAcknowledgementReceiveException(ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(ALTERNATE_EXCEPTION_MESSAGE)); @@ -109,10 +104,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorSix() throws Exception { + public void testConstructorSix() { instance = new MllpAcknowledgementReceiveException( ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); @@ -125,10 +119,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorSeven() throws Exception { + public void testConstructorSeven() { instance = new MllpAcknowledgementReceiveException(ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(ALTERNATE_EXCEPTION_MESSAGE)); @@ -140,10 +133,9 @@ public class MllpAcknowledgementReceiveExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorEight() throws Exception { + public void testConstructorEight() { instance = new MllpAcknowledgementReceiveException( ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementTimeoutExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementTimeoutExceptionTest.java index 1b1813efc82..dadbd11c7bf 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementTimeoutExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpAcknowledgementTimeoutExceptionTest.java @@ -34,10 +34,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpAcknowledgementTimeoutException(HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementTimeoutException.EXCEPTION_MESSAGE)); @@ -49,10 +48,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpAcknowledgementTimeoutException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementTimeoutException.EXCEPTION_MESSAGE)); @@ -64,10 +62,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorThree() throws Exception { + public void testConstructorThree() { instance = new MllpAcknowledgementTimeoutException(HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementTimeoutException.EXCEPTION_MESSAGE)); @@ -79,10 +76,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFour() throws Exception { + public void testConstructorFour() { instance = new MllpAcknowledgementTimeoutException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpAcknowledgementTimeoutException.EXCEPTION_MESSAGE)); @@ -94,10 +90,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFive() throws Exception { + public void testConstructorFive() { instance = new MllpAcknowledgementTimeoutException(ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(ALTERNATE_EXCEPTION_MESSAGE)); @@ -109,10 +104,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorSix() throws Exception { + public void testConstructorSix() { instance = new MllpAcknowledgementTimeoutException( ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); @@ -125,10 +119,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorSeven() throws Exception { + public void testConstructorSeven() { instance = new MllpAcknowledgementTimeoutException(ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(ALTERNATE_EXCEPTION_MESSAGE)); @@ -140,10 +133,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorEight() throws Exception { + public void testConstructorEight() { instance = new MllpAcknowledgementTimeoutException( ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); @@ -156,10 +148,9 @@ public class MllpAcknowledgementTimeoutExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGetHl7Acknowledgement() throws Exception { + public void testGetHl7Acknowledgement() { instance = new MllpAcknowledgementTimeoutException( ALTERNATE_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); assertArrayEquals(HL7_ACKNOWLEDGEMENT_BYTES, instance.getHl7Acknowledgement()); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationErrorAcknowledgementExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationErrorAcknowledgementExceptionTest.java index dc0ed997e6a..88cb4efbd50 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationErrorAcknowledgementExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationErrorAcknowledgementExceptionTest.java @@ -33,10 +33,9 @@ public class MllpApplicationErrorAcknowledgementExceptionTest extends MllpExcept /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpApplicationErrorAcknowledgementException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpApplicationErrorAcknowledgementException.EXCEPTION_MESSAGE)); @@ -48,10 +47,9 @@ public class MllpApplicationErrorAcknowledgementExceptionTest extends MllpExcept /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpApplicationErrorAcknowledgementException( HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); @@ -64,10 +62,9 @@ public class MllpApplicationErrorAcknowledgementExceptionTest extends MllpExcept /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGetAcknowledgmentType() throws Exception { + public void testGetAcknowledgmentType() { instance = new MllpApplicationErrorAcknowledgementException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertEquals("AE", instance.getAcknowledgmentType()); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationRejectAcknowledgementExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationRejectAcknowledgementExceptionTest.java index 642d9e0a80f..dd373110c21 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationRejectAcknowledgementExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpApplicationRejectAcknowledgementExceptionTest.java @@ -33,10 +33,9 @@ public class MllpApplicationRejectAcknowledgementExceptionTest extends MllpExcep /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpApplicationRejectAcknowledgementException( HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); @@ -49,10 +48,9 @@ public class MllpApplicationRejectAcknowledgementExceptionTest extends MllpExcep /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpApplicationRejectAcknowledgementException( HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); @@ -65,10 +63,9 @@ public class MllpApplicationRejectAcknowledgementExceptionTest extends MllpExcep /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGetAcknowledgmentType() throws Exception { + public void testGetAcknowledgmentType() { instance = new MllpApplicationRejectAcknowledgementException( HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitErrorAcknowledgementExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitErrorAcknowledgementExceptionTest.java index 986ec51bc0d..6c493d07fa6 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitErrorAcknowledgementExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitErrorAcknowledgementExceptionTest.java @@ -33,10 +33,9 @@ public class MllpCommitErrorAcknowledgementExceptionTest extends MllpExceptionTe /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpCommitErrorAcknowledgementException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpCommitErrorAcknowledgementException.EXCEPTION_MESSAGE)); @@ -48,10 +47,9 @@ public class MllpCommitErrorAcknowledgementExceptionTest extends MllpExceptionTe /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpCommitErrorAcknowledgementException( HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); @@ -64,10 +62,9 @@ public class MllpCommitErrorAcknowledgementExceptionTest extends MllpExceptionTe /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGetAcknowledgmentType() throws Exception { + public void testGetAcknowledgmentType() { instance = new MllpCommitErrorAcknowledgementException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertEquals("CE", instance.getAcknowledgmentType()); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitRejectAcknowledgementExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitRejectAcknowledgementExceptionTest.java index 89daad6f771..f386bd561e3 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitRejectAcknowledgementExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpCommitRejectAcknowledgementExceptionTest.java @@ -33,10 +33,9 @@ public class MllpCommitRejectAcknowledgementExceptionTest extends MllpExceptionT /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpCommitRejectAcknowledgementException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(MllpCommitRejectAcknowledgementException.EXCEPTION_MESSAGE)); @@ -48,10 +47,9 @@ public class MllpCommitRejectAcknowledgementExceptionTest extends MllpExceptionT /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpCommitRejectAcknowledgementException( HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); @@ -64,10 +62,9 @@ public class MllpCommitRejectAcknowledgementExceptionTest extends MllpExceptionT /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGetAcknowledgmentType() throws Exception { + public void testGetAcknowledgmentType() { instance = new MllpCommitRejectAcknowledgementException(HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertEquals("CR", instance.getAcknowledgmentType()); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpExceptionTest.java index 2f5a8619268..0b090bad7c5 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpExceptionTest.java @@ -31,12 +31,12 @@ public class MllpExceptionTest extends MllpExceptionTestSupport { MllpException instance; @BeforeEach - public void setUp() throws Exception { + public void setUp() { instance = new MllpException(EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); } @Test - public void testGetHl7MessageBytes() throws Exception { + public void testGetHl7MessageBytes() { instance = new MllpException(EXCEPTION_MESSAGE, LOG_PHI_TRUE); assertNull(instance.getHl7MessageBytes()); @@ -72,7 +72,7 @@ public class MllpExceptionTest extends MllpExceptionTestSupport { } @Test - public void testGetHl7AcknowledgementBytes() throws Exception { + public void testGetHl7AcknowledgementBytes() { instance = new MllpException(EXCEPTION_MESSAGE, LOG_PHI_TRUE); assertNull(instance.getHl7AcknowledgementBytes()); @@ -117,35 +117,35 @@ public class MllpExceptionTest extends MllpExceptionTestSupport { } @Test - public void testNullHl7Message() throws Exception { + public void testNullHl7Message() { instance = new MllpException(EXCEPTION_MESSAGE, null, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertEquals(expectedMessage(null, HL7_ACKNOWLEDGEMENT), instance.getMessage()); } @Test - public void testEmptyHl7Message() throws Exception { + public void testEmptyHl7Message() { instance = new MllpException(EXCEPTION_MESSAGE, EMPTY_BYTE_ARRAY, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertEquals(expectedMessage(null, HL7_ACKNOWLEDGEMENT), instance.getMessage()); } @Test - public void testNullHl7Acknowledgement() throws Exception { + public void testNullHl7Acknowledgement() { instance = new MllpException(EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, NULL_BYTE_ARRAY, LOG_PHI_TRUE); assertEquals(expectedMessage(HL7_MESSAGE, null), instance.getMessage()); } @Test - public void testEmptyAcknowledgement() throws Exception { + public void testEmptyAcknowledgement() { instance = new MllpException(EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, EMPTY_BYTE_ARRAY, LOG_PHI_TRUE); assertEquals(expectedMessage(HL7_MESSAGE, null), instance.getMessage()); } @Test - public void testNullHl7Payloads() throws Exception { + public void testNullHl7Payloads() { instance = new MllpException(EXCEPTION_MESSAGE, NULL_BYTE_ARRAY, NULL_BYTE_ARRAY, LOG_PHI_TRUE); assertEquals(expectedMessage(null, null), instance.getMessage()); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpIdleTimeoutStrategyTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpIdleTimeoutStrategyTest.java index 29beac29f3b..66a53332e87 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpIdleTimeoutStrategyTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpIdleTimeoutStrategyTest.java @@ -174,11 +174,11 @@ public class MllpIdleTimeoutStrategyTest extends CamelTestSupport { } @Override - protected RoutesBuilder createRouteBuilder() throws Exception { + protected RoutesBuilder createRouteBuilder() { return new RouteBuilder() { @Override - public void configure() throws Exception { + public void configure() { route("mllp-sender-default", defaultStrategySource.getDefaultEndpoint(), defaultStrategyEndpoint); route("mllp-sender-reset", resetStrategySource.getDefaultEndpoint(), resetStrategyEndpoint); route("mllp-sender-close", closeStrategySource.getDefaultEndpoint(), closeStrategyEndpoint); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidAcknowledgementExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidAcknowledgementExceptionTest.java index fe7c1fd210b..42777e2d22b 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidAcknowledgementExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidAcknowledgementExceptionTest.java @@ -34,10 +34,9 @@ public class MllpInvalidAcknowledgementExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpInvalidAcknowledgementException( EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); @@ -50,10 +49,9 @@ public class MllpInvalidAcknowledgementExceptionTest extends MllpExceptionTestSu /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpInvalidAcknowledgementException( EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidMessageExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidMessageExceptionTest.java index c2405224cc6..955a107c267 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidMessageExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpInvalidMessageExceptionTest.java @@ -34,10 +34,9 @@ public class MllpInvalidMessageExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpInvalidMessageException(EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(EXCEPTION_MESSAGE)); @@ -49,10 +48,9 @@ public class MllpInvalidMessageExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpInvalidMessageException(EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertTrue(instance.getMessage().startsWith(EXCEPTION_MESSAGE)); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpMaxConcurrentConsumersTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpMaxConcurrentConsumersTest.java index 646d7358814..bc714871781 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpMaxConcurrentConsumersTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpMaxConcurrentConsumersTest.java @@ -108,7 +108,7 @@ public class MllpMaxConcurrentConsumersTest extends CamelTestSupport { RouteBuilder builder = new RouteBuilder() { @Override - public void configure() throws Exception { + public void configure() { String routeId = "mllp-max-concurrent-consumers-route"; fromF("mllp://%s:%d?maxConcurrentConsumers=%d&autoAck=true&connectTimeout=100&receiveTimeout=1000", diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpNegativeAcknowledgementExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpNegativeAcknowledgementExceptionTest.java index c36346fee67..2edab4415bf 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpNegativeAcknowledgementExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpNegativeAcknowledgementExceptionTest.java @@ -34,10 +34,9 @@ public class MllpNegativeAcknowledgementExceptionTest extends MllpExceptionTestS /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpNegativeAcknowledgementExceptionStub( EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); @@ -50,10 +49,9 @@ public class MllpNegativeAcknowledgementExceptionTest extends MllpExceptionTestS /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpNegativeAcknowledgementExceptionStub( EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); @@ -66,10 +64,9 @@ public class MllpNegativeAcknowledgementExceptionTest extends MllpExceptionTestS /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGetAcknowledgmentType() throws Exception { + public void testGetAcknowledgmentType() { instance = new MllpNegativeAcknowledgementExceptionStub( EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackInOnlyTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackInOnlyTest.java index cc30aa8aa2a..f6fc740f1c0 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackInOnlyTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackInOnlyTest.java @@ -51,7 +51,7 @@ public class MllpProducerConsumerLoopbackInOnlyTest extends CamelTestSupport { } @Override - protected RouteBuilder[] createRouteBuilders() throws Exception { + protected RouteBuilder[] createRouteBuilders() { String mllpHost = "localhost"; int mllpPort = AvailablePortFinder.getNextAvailable(); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackTest.java index 1b8d9872d41..6d300bb7be7 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpProducerConsumerLoopbackTest.java @@ -51,7 +51,7 @@ public class MllpProducerConsumerLoopbackTest extends CamelTestSupport { MockEndpoint acknowledged; @BeforeAll - public static void setUpClass() throws Exception { + public static void setUpClass() { assumeTrue(System.getenv("BUILD_ID") == null, "Skipping test running in CI server - Fails sometimes on CI server with address already in use"); } @@ -67,7 +67,7 @@ public class MllpProducerConsumerLoopbackTest extends CamelTestSupport { } @Override - protected RouteBuilder[] createRouteBuilders() throws Exception { + protected RouteBuilder[] createRouteBuilders() { RouteBuilder[] builders = new RouteBuilder[2]; builders[0] = new RouteBuilder() { diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpReceiveExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpReceiveExceptionTest.java index 8c2819af6fe..78c75c91096 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpReceiveExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpReceiveExceptionTest.java @@ -34,10 +34,9 @@ public class MllpReceiveExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpReceiveException(TEST_EXCEPTION_MESSAGE, LOG_PHI_TRUE); assertNull(instance.getCause()); @@ -49,10 +48,9 @@ public class MllpReceiveExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpReceiveException(TEST_EXCEPTION_MESSAGE, CAUSE, LOG_PHI_TRUE); assertSame(CAUSE, instance.getCause()); @@ -64,10 +62,9 @@ public class MllpReceiveExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorThree() throws Exception { + public void testConstructorThree() { instance = new MllpReceiveException(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertNull(instance.getCause()); @@ -79,10 +76,9 @@ public class MllpReceiveExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFour() throws Exception { + public void testConstructorFour() { instance = new MllpReceiveException(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertNull(instance.getCause()); @@ -94,10 +90,9 @@ public class MllpReceiveExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFive() throws Exception { + public void testConstructorFive() { instance = new MllpReceiveException(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertSame(CAUSE, instance.getCause()); @@ -109,10 +104,9 @@ public class MllpReceiveExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorSix() throws Exception { + public void testConstructorSix() { instance = new MllpReceiveException( TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpSocketExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpSocketExceptionTest.java index 216e45d9384..92ccb892aa5 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpSocketExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpSocketExceptionTest.java @@ -33,10 +33,9 @@ public class MllpSocketExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpSocketException(TEST_EXCEPTION_MESSAGE); assertNull(instance.getCause()); @@ -46,10 +45,9 @@ public class MllpSocketExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpSocketException(TEST_EXCEPTION_MESSAGE, CAUSE); assertNotNull(instance.getCause()); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerConnectionErrorTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerConnectionErrorTest.java index 35efcd54b0d..aff87d62363 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerConnectionErrorTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerConnectionErrorTest.java @@ -71,7 +71,7 @@ public class MllpTcpClientProducerConnectionErrorTest extends CamelTestSupport { } @Override - protected RouteBuilder createRouteBuilder() throws Exception { + protected RouteBuilder createRouteBuilder() { return new RouteBuilder() { String routeId = "mllp-sender"; diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerIdleConnectionTimeoutTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerIdleConnectionTimeoutTest.java index 66d290ac7ef..54044d4dabb 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerIdleConnectionTimeoutTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpClientProducerIdleConnectionTimeoutTest.java @@ -75,7 +75,7 @@ public class MllpTcpClientProducerIdleConnectionTimeoutTest extends CamelTestSup } @Override - protected RouteBuilder createRouteBuilder() throws Exception { + protected RouteBuilder createRouteBuilder() { return new RouteBuilder() { String routeId = "mllp-sender"; diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerCharsetTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerCharsetTest.java index 921fbaeade2..d826e4c7ae3 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerCharsetTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerCharsetTest.java @@ -69,7 +69,7 @@ public class MllpTcpServerCharsetTest extends CamelTestSupport { } @Override - protected RouteBuilder createRouteBuilder() throws Exception { + protected RouteBuilder createRouteBuilder() { return new RouteBuilder() { String routeId = "mllp-sender"; diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerBindTimeoutTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerBindTimeoutTest.java index 51f06155e71..958bd8a0699 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerBindTimeoutTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerBindTimeoutTest.java @@ -67,7 +67,7 @@ public class MllpTcpServerConsumerBindTimeoutTest extends CamelTestSupport { int responseTimeout = 5000; @Override - public void configure() throws Exception { + public void configure() { String routeId = "mllp-test-receiver-route"; onCompletion() diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMessageHeadersTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMessageHeadersTest.java index e8356254c36..0c25b7cf321 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMessageHeadersTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMessageHeadersTest.java @@ -147,7 +147,7 @@ public class MllpTcpServerConsumerMessageHeadersTest extends CamelTestSupport { int responseTimeout = 5000; @Override - public void configure() throws Exception { + public void configure() { String routeId = "mllp-test-receiver-route"; onCompletion() diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMulitpleTcpPacketTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMulitpleTcpPacketTest.java index de398cc5a79..9541f92be6d 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMulitpleTcpPacketTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerMulitpleTcpPacketTest.java @@ -64,7 +64,7 @@ public class MllpTcpServerConsumerMulitpleTcpPacketTest extends CamelTestSupport String routeId = "mllp-receiver"; @Override - public void configure() throws Exception { + public void configure() { onCompletion() .log(LoggingLevel.INFO, routeId, "Test route complete"); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithoutValidationTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithoutValidationTest.java index ed248839966..2f3d3256d91 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithoutValidationTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerOptionalEndOfDataWithoutValidationTest.java @@ -63,7 +63,7 @@ public class MllpTcpServerConsumerOptionalEndOfDataWithoutValidationTest } @Override - public void testMessageContainingEmbeddedEndOfBlock() throws Exception { + public void testMessageContainingEmbeddedEndOfBlock() { expectedCompleteCount = 1; setExpectedCounts(); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerTransactionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerTransactionTest.java index e5f6ee043cc..bceae6312ce 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerTransactionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpTcpServerConsumerTransactionTest.java @@ -74,7 +74,7 @@ public class MllpTcpServerConsumerTransactionTest extends CamelTestSupport { } @BindToRegistry("target") - public SjmsComponent addTargetComponent() throws Exception { + public SjmsComponent addTargetComponent() { SjmsComponent target = new SjmsComponent(); target.setConnectionFactory(new ActiveMQConnectionFactory(service.getVmURL())); @@ -93,7 +93,7 @@ public class MllpTcpServerConsumerTransactionTest extends CamelTestSupport { int responseTimeout = 5000; @Override - public void configure() throws Exception { + public void configure() { String routeId = "mllp-test-receiver-route"; onCompletion() diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpWriteExceptionTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpWriteExceptionTest.java index 615319d27ad..c34fac5f278 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpWriteExceptionTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/MllpWriteExceptionTest.java @@ -34,10 +34,9 @@ public class MllpWriteExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorOne() throws Exception { + public void testConstructorOne() { instance = new MllpWriteException(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, LOG_PHI_TRUE); assertNull(instance.getCause()); @@ -49,10 +48,9 @@ public class MllpWriteExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorTwo() throws Exception { + public void testConstructorTwo() { instance = new MllpWriteException(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, LOG_PHI_TRUE); assertNull(instance.getCause()); @@ -64,10 +62,9 @@ public class MllpWriteExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorThree() throws Exception { + public void testConstructorThree() { instance = new MllpWriteException(TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, CAUSE, LOG_PHI_TRUE); assertSame(CAUSE, instance.getCause()); @@ -79,10 +76,9 @@ public class MllpWriteExceptionTest extends MllpExceptionTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorFour() throws Exception { + public void testConstructorFour() { instance = new MllpWriteException( TEST_EXCEPTION_MESSAGE, HL7_MESSAGE_BYTES, HL7_ACKNOWLEDGEMENT_BYTES, CAUSE, LOG_PHI_TRUE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpClientProducerEndOfDataAndValidationTestSupport.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpClientProducerEndOfDataAndValidationTestSupport.java index 05614522709..bc102be4b93 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpClientProducerEndOfDataAndValidationTestSupport.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpClientProducerEndOfDataAndValidationTestSupport.java @@ -118,7 +118,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Override - protected RouteBuilder createRouteBuilder() throws Exception { + protected RouteBuilder createRouteBuilder() { return new RouteBuilder() { String routeId = "mllp-sender"; @@ -164,7 +164,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends }; } - protected void setExpectedCounts() throws Exception { + protected void setExpectedCounts() { aa.expectedMessageCount(expectedAACount); ae.expectedMessageCount(expectedAECount); ar.expectedMessageCount(expectedARCount); @@ -184,7 +184,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public void testSendSingleMessageWithEndOfDataByte() throws Exception { + public void testSendSingleMessageWithEndOfDataByte() { aa.expectedMessageCount(1); source.sendBody(Hl7TestMessageGenerator.generateMessage()); @@ -208,7 +208,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testSendSingleMessageWithoutEndOfData() throws Exception; + public abstract void testSendSingleMessageWithoutEndOfData(); protected void runSendSingleMessageWithoutEndOfData() throws Exception { setExpectedCounts(); @@ -219,9 +219,9 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testSendMultipleMessagesWithoutEndOfDataByte() throws Exception; + public abstract void testSendMultipleMessagesWithoutEndOfDataByte(); - protected void runSendMultipleMessagesWithoutEndOfDataByte() throws Exception { + protected void runSendMultipleMessagesWithoutEndOfDataByte() { NotifyBuilder[] complete = new NotifyBuilder[expectedAACount]; for (int i = 0; i < expectedAACount; ++i) { complete[i] = new NotifyBuilder(context).whenDone(i + 1).create(); @@ -345,7 +345,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testEmptyAcknowledgement() throws Exception; + public abstract void testEmptyAcknowledgement(); protected void runEmptyAcknowledgement(MockEndpoint expectedEndpoint) throws Exception { setExpectedCounts(); @@ -358,7 +358,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testInvalidAcknowledgement() throws Exception; + public abstract void testInvalidAcknowledgement(); protected void runInvalidAcknowledgement(MockEndpoint expectedEndpoint) throws Exception { final String badAcknowledgement = "A VERY BAD ACKNOWLEDGEMENT"; @@ -376,7 +376,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testMissingEndOfDataByte() throws Exception; + public abstract void testMissingEndOfDataByte(); /** * NOTE: Set expectation variables BEFORE calling this method. @@ -446,7 +446,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testSendMultipleMessagesWithoutSomeEndOfDataByte() throws Exception; + public abstract void testSendMultipleMessagesWithoutSomeEndOfDataByte(); protected void runSendMultipleMessagesWithoutSomeEndOfDataByte() throws Exception { setExpectedCounts(); @@ -467,7 +467,7 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testInvalidAcknowledgementContainingEmbeddedStartOfBlock() throws Exception; + public abstract void testInvalidAcknowledgementContainingEmbeddedStartOfBlock(); /** * NOTE: Set expectation variables BEFORE calling this method. @@ -485,14 +485,13 @@ public abstract class TcpClientProducerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testInvalidAcknowledgementContainingEmbeddedEndOfBlockByte() throws Exception; + public abstract void testInvalidAcknowledgementContainingEmbeddedEndOfBlockByte(); /** * NOTE: Set expectation variables BEFORE calling this method. - * - * @throws Exception + * */ - protected void runInvalidAcknowledgementContainingEmbeddedEndOfBlockByte() throws Exception { + protected void runInvalidAcknowledgementContainingEmbeddedEndOfBlockByte() { final String badAcknowledgement = EXPECTED_AA.replaceFirst("RISTECH", "RISTECH" + MllpProtocolConstants.END_OF_BLOCK); mllpServer.setAcknowledgementString(badAcknowledgement); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerAcknowledgementTestSupport.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerAcknowledgementTestSupport.java index 2dad7648e83..972bc477a39 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerAcknowledgementTestSupport.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerAcknowledgementTestSupport.java @@ -90,7 +90,7 @@ public abstract class TcpServerConsumerAcknowledgementTestSupport extends CamelT int responseTimeout = 5000; @Override - public void configure() throws Exception { + public void configure() { String routeId = "mllp-test-receiver-route"; onException(MllpInvalidAcknowledgementException.class) diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerEndOfDataAndValidationTestSupport.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerEndOfDataAndValidationTestSupport.java index bd80733e2af..f7b10601b1a 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerEndOfDataAndValidationTestSupport.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/TcpServerConsumerEndOfDataAndValidationTestSupport.java @@ -87,7 +87,7 @@ public abstract class TcpServerConsumerEndOfDataAndValidationTestSupport extends return new RouteBuilder() { @Override - public void configure() throws Exception { + public void configure() { String routeId = "mllp-test-receiver-route"; onException(MllpInvalidMessageException.class) @@ -271,7 +271,7 @@ public abstract class TcpServerConsumerEndOfDataAndValidationTestSupport extends @Test public abstract void testInvalidMessage() throws Exception; - protected void runInvalidMessage() throws Exception { + protected void runInvalidMessage() { setExpectedCounts(); mllpClient.sendFramedData("INVALID PAYLOAD"); @@ -345,7 +345,7 @@ public abstract class TcpServerConsumerEndOfDataAndValidationTestSupport extends } @Test - public abstract void testMessageContainingEmbeddedEndOfBlock() throws Exception; + public abstract void testMessageContainingEmbeddedEndOfBlock(); @Test public abstract void testInvalidMessageContainingEmbeddedEndOfBlock() throws Exception; @@ -416,7 +416,7 @@ public abstract class TcpServerConsumerEndOfDataAndValidationTestSupport extends } @Test - public void testInitialMessageWithoutEndOfDataByte() throws Exception { + public void testInitialMessageWithoutEndOfDataByte() { setExpectedCounts(); mllpClient.setSendEndOfData(false); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/Hl7UtilTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/Hl7UtilTest.java index adc87f6235a..88f35bb7a3d 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/Hl7UtilTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/Hl7UtilTest.java @@ -107,14 +107,14 @@ public class Hl7UtilTest { private Charset charset = Charset.forName("ISO_8859_1"); @Test - public void testGenerateInvalidPayloadExceptionMessage() throws Exception { + public void testGenerateInvalidPayloadExceptionMessage() { String message = hl7util.generateInvalidPayloadExceptionMessage(TEST_MESSAGE.getBytes()); assertNull(message, "Valid payload should result in a null message"); } @Test - public void testGenerateInvalidPayloadExceptionMessageWithLengthLargerThanArraySize() throws Exception { + public void testGenerateInvalidPayloadExceptionMessageWithLengthLargerThanArraySize() { byte[] payload = TEST_MESSAGE.getBytes(); String message = hl7util.generateInvalidPayloadExceptionMessage(payload, payload.length * 2); @@ -122,7 +122,7 @@ public class Hl7UtilTest { } @Test - public void testGenerateInvalidPayloadExceptionMessageWithLengthSmallerThanArraySize() throws Exception { + public void testGenerateInvalidPayloadExceptionMessageWithLengthSmallerThanArraySize() { byte[] payload = TEST_MESSAGE.getBytes(); String message = hl7util.generateInvalidPayloadExceptionMessage(payload, 10); @@ -130,7 +130,7 @@ public class Hl7UtilTest { } @Test - public void testGenerateInvalidPayloadExceptionMessageWithNullPayload() throws Exception { + public void testGenerateInvalidPayloadExceptionMessageWithNullPayload() { assertEquals("HL7 payload is null", hl7util.generateInvalidPayloadExceptionMessage(null)); assertEquals("HL7 payload is null", hl7util.generateInvalidPayloadExceptionMessage(null, 1234)); @@ -150,7 +150,7 @@ public class Hl7UtilTest { } @Test - public void testGenerateInvalidPayloadExceptionMessageWithEmptyPayload() throws Exception { + public void testGenerateInvalidPayloadExceptionMessageWithEmptyPayload() { byte[] payload = new byte[0]; assertEquals("HL7 payload is empty", hl7util.generateInvalidPayloadExceptionMessage(payload)); @@ -158,7 +158,7 @@ public class Hl7UtilTest { } @Test - public void testGenerateInvalidPayloadExceptionMessageWithEmbeddedStartOfBlock() throws Exception { + public void testGenerateInvalidPayloadExceptionMessageWithEmbeddedStartOfBlock() { byte[] basePayload = TEST_MESSAGE.getBytes(); ByteArrayOutputStream payloadStream = new ByteArrayOutputStream(basePayload.length + 1); @@ -175,7 +175,7 @@ public class Hl7UtilTest { } @Test - public void testGenerateInvalidPayloadExceptionMessageWithEmbeddedEndOfBlock() throws Exception { + public void testGenerateInvalidPayloadExceptionMessageWithEmbeddedEndOfBlock() { byte[] basePayload = TEST_MESSAGE.getBytes(); ByteArrayOutputStream payloadStream = new ByteArrayOutputStream(basePayload.length + 1); @@ -210,10 +210,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGenerateAcknowledgementPayloadFromNullMessage() throws Exception { + public void testGenerateAcknowledgementPayloadFromNullMessage() { MllpSocketBuffer mllpSocketBuffer = new MllpSocketBuffer(new MllpEndpointStub()); assertThrows(MllpAcknowledgementGenerationException.class, () -> hl7util.generateAcknowledgementPayload(mllpSocketBuffer, null, "AA")); @@ -222,10 +221,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGenerateAcknowledgementPayloadFromEmptyMessage() throws Exception { + public void testGenerateAcknowledgementPayloadFromEmptyMessage() { MllpSocketBuffer mllpSocketBuffer = new MllpSocketBuffer(new MllpEndpointStub()); assertThrows(MllpAcknowledgementGenerationException.class, () -> hl7util.generateAcknowledgementPayload(mllpSocketBuffer, new byte[0], "AA")); @@ -234,10 +232,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGenerateAcknowledgementPayloadWithoutEnoughFields() throws Exception { + public void testGenerateAcknowledgementPayloadWithoutEnoughFields() { final byte[] testMessage = TEST_MESSAGE.replace("||ORM^O01|00001|D|2.3|||||||", "").getBytes(); MllpSocketBuffer mllpSocketBuffer = new MllpSocketBuffer(new MllpEndpointStub()); @@ -270,10 +267,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConvertStringToPrintFriendlyString() throws Exception { + public void testConvertStringToPrintFriendlyString() { assertEquals(hl7util.NULL_REPLACEMENT_VALUE, hl7util.convertToPrintFriendlyString((String) null)); assertEquals(hl7util.EMPTY_REPLACEMENT_VALUE, hl7util.convertToPrintFriendlyString("")); assertEquals(EXPECTED_MESSAGE, hl7util.convertToPrintFriendlyString(TEST_MESSAGE)); @@ -282,10 +278,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConvertBytesToPrintFriendlyString() throws Exception { + public void testConvertBytesToPrintFriendlyString() { assertEquals(hl7util.NULL_REPLACEMENT_VALUE, hl7util.convertToPrintFriendlyString((byte[]) null)); assertEquals(hl7util.EMPTY_REPLACEMENT_VALUE, hl7util.convertToPrintFriendlyString(new byte[0])); assertEquals(EXPECTED_MESSAGE, hl7util.convertToPrintFriendlyString(TEST_MESSAGE_BYTES)); @@ -294,10 +289,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConvertBytesToPrintFriendlyStringWithStartAndEndPositions() throws Exception { + public void testConvertBytesToPrintFriendlyStringWithStartAndEndPositions() { assertEquals(Hl7Util.NULL_REPLACEMENT_VALUE, hl7util.convertToPrintFriendlyString((byte[]) null, 0, 1000)); assertEquals(Hl7Util.NULL_REPLACEMENT_VALUE, hl7util.convertToPrintFriendlyString((byte[]) null, 200, 1000)); assertEquals(Hl7Util.NULL_REPLACEMENT_VALUE, hl7util.convertToPrintFriendlyString((byte[]) null, -200, 1000)); @@ -346,10 +340,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testBytesToPrintFriendlyStringBuilder() throws Exception { + public void testBytesToPrintFriendlyStringBuilder() { assertEquals(hl7util.NULL_REPLACEMENT_VALUE, hl7util.bytesToPrintFriendlyStringBuilder((byte[]) null).toString()); assertEquals(hl7util.EMPTY_REPLACEMENT_VALUE, hl7util.bytesToPrintFriendlyStringBuilder(new byte[0]).toString()); assertEquals(EXPECTED_MESSAGE, hl7util.bytesToPrintFriendlyStringBuilder(TEST_MESSAGE_BYTES).toString()); @@ -358,10 +351,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testBytesToPrintFriendlyStringBuilderWithStartAndEndPositions() throws Exception { + public void testBytesToPrintFriendlyStringBuilderWithStartAndEndPositions() { assertEquals(hl7util.NULL_REPLACEMENT_VALUE, hl7util.bytesToPrintFriendlyStringBuilder((byte[]) null, 0, 1000).toString()); assertEquals(hl7util.NULL_REPLACEMENT_VALUE, @@ -429,10 +421,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testAppendBytesAsPrintFriendlyString() throws Exception { + public void testAppendBytesAsPrintFriendlyString() { StringBuilder builder = null; try { @@ -458,10 +449,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testAppendBytesAsPrintFriendlyStringWithStartAndEndPositions() throws Exception { + public void testAppendBytesAsPrintFriendlyStringWithStartAndEndPositions() { StringBuilder builder = null; try { @@ -599,10 +589,9 @@ public class Hl7UtilTest { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testAppendCharacterAsPrintFriendlyString() throws Exception { + public void testAppendCharacterAsPrintFriendlyString() { StringBuilder builder = null; try { @@ -630,7 +619,7 @@ public class Hl7UtilTest { } @Test - public void testGetCharacterAsPrintFriendlyString() throws Exception { + public void testGetCharacterAsPrintFriendlyString() { assertEquals("<0x0B VT>", Hl7Util.getCharacterAsPrintFriendlyString(MllpProtocolConstants.START_OF_BLOCK)); assertEquals("<0x1C FS>", Hl7Util.getCharacterAsPrintFriendlyString(MllpProtocolConstants.END_OF_BLOCK)); assertEquals("<0x0D CR>", Hl7Util.getCharacterAsPrintFriendlyString(MllpProtocolConstants.SEGMENT_DELIMITER)); @@ -639,28 +628,28 @@ public class Hl7UtilTest { } @Test - public void testFindMsh18WhenExistsWithoutTrailingPipe() throws Exception { + public void testFindMsh18WhenExistsWithoutTrailingPipe() { final String testMessage = MSH_SEGMENT + "||||||8859/1" + '\r' + REMAINING_SEGMENTS; assertEquals("8859/1", hl7util.findMsh18(testMessage.getBytes(), charset)); } @Test - public void testFindMsh18WhenExistsWithTrailingPipe() throws Exception { + public void testFindMsh18WhenExistsWithTrailingPipe() { final String testMessage = MSH_SEGMENT + "||||||8859/1|" + '\r' + REMAINING_SEGMENTS; assertEquals("8859/1", hl7util.findMsh18(testMessage.getBytes(), charset)); } @Test - public void testFindMsh18WhenMissingWithoutTrailingPipe() throws Exception { + public void testFindMsh18WhenMissingWithoutTrailingPipe() { final String testMessage = MSH_SEGMENT + "||||||" + '\r' + REMAINING_SEGMENTS; assertEquals("", hl7util.findMsh18(testMessage.getBytes(), charset)); } @Test - public void testFindMsh18WhenMissingWithTrailingPipe() throws Exception { + public void testFindMsh18WhenMissingWithTrailingPipe() { final String testMessage = MSH_SEGMENT + "|||||||" + '\r' + REMAINING_SEGMENTS; assertEquals("", hl7util.findMsh18(testMessage.getBytes(), charset)); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferTest.java index 638d4ffea93..52cbeff91d2 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferTest.java @@ -33,10 +33,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testConstructorWithNullEndpoing() throws Exception { + public void testConstructorWithNullEndpoing() { try { new MllpSocketBuffer(null); fail("Constructor should have thrown an exception with a null Endpoint argument"); @@ -289,10 +288,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testGetStartOfBlockIndex() throws Exception { + public void testGetStartOfBlockIndex() { int expected = -1; assertEquals(expected, instance.getStartOfBlockIndex(), "Unexpected initial value"); @@ -308,10 +306,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void tesGgetEndOfBlockIndex() throws Exception { + public void tesGgetEndOfBlockIndex() { int expected = -1; assertEquals(expected, instance.getEndOfBlockIndex(), "Unexpected initial value"); @@ -327,10 +324,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testHasCompleteEnvelopeWithRequiredEndOfData() throws Exception { + public void testHasCompleteEnvelopeWithRequiredEndOfData() { endpoint.setRequireEndOfData(true); assertFalse(instance.hasCompleteEnvelope(), "Unexpected initial value"); @@ -353,10 +349,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testHasCompleteEnvelopeWithOptionalEndOfData() throws Exception { + public void testHasCompleteEnvelopeWithOptionalEndOfData() { endpoint.setRequireEndOfData(false); assertFalse(instance.hasCompleteEnvelope(), "Unexpected initial value"); @@ -379,10 +374,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testHasStartOfBlock() throws Exception { + public void testHasStartOfBlock() { assertFalse(instance.hasStartOfBlock(), "Unexpected initial value"); instance.write(MllpProtocolConstants.START_OF_BLOCK); @@ -404,10 +398,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testHasEndOfBlock() throws Exception { + public void testHasEndOfBlock() { assertFalse(instance.hasEndOfBlock(), "Unexpected initial value"); instance.write(MllpProtocolConstants.END_OF_BLOCK); @@ -447,10 +440,9 @@ public class MllpSocketBufferTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testHasEndOfData() throws Exception { + public void testHasEndOfData() { assertFalse(instance.hasEndOfData(), "Unexpected initial value"); // Test just the END_OF_DATA diff --git a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferWriteTest.java b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferWriteTest.java index 2f2c0d1b096..19f30ada6ce 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferWriteTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/component/mllp/internal/MllpSocketBufferWriteTest.java @@ -33,10 +33,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteIntWithStartOfBlock() throws Exception { + public void testWriteIntWithStartOfBlock() { instance.write(MllpProtocolConstants.START_OF_BLOCK); assertEquals(1, instance.size()); @@ -47,10 +46,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteIntWithEndOfBlock() throws Exception { + public void testWriteIntWithEndOfBlock() { instance.write(MllpProtocolConstants.END_OF_BLOCK); assertEquals(1, instance.size()); @@ -61,10 +59,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteIntWithEndOfData() throws Exception { + public void testWriteIntWithEndOfData() { instance.write(MllpProtocolConstants.END_OF_DATA); assertEquals(1, instance.size()); @@ -75,10 +72,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteBytesWithNullArray() throws Exception { + public void testWriteBytesWithNullArray() { instance.write((byte[]) null); assertEquals(0, instance.size()); @@ -89,10 +85,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteBytesWithEmptyArray() throws Exception { + public void testWriteBytesWithEmptyArray() { instance.write(new byte[0]); assertEquals(0, instance.size()); @@ -117,10 +112,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteBytesWithoutEnvelope() throws Exception { + public void testWriteBytesWithoutEnvelope() { instance.write("BLAH".getBytes()); assertEquals(4, instance.size()); @@ -187,10 +181,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteByteArraySliceWithNullArray() throws Exception { + public void testWriteByteArraySliceWithNullArray() { instance.write(null, 0, 5); assertEquals(0, instance.size()); @@ -201,10 +194,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteByteArraySliceWithEmptyArray() throws Exception { + public void testWriteByteArraySliceWithEmptyArray() { instance.write(new byte[0], 0, 5); assertEquals(0, instance.size()); @@ -215,10 +207,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteByteArraySliceWithNegativeOffset() throws Exception { + public void testWriteByteArraySliceWithNegativeOffset() { byte[] payload = "BLAH".getBytes(); try { @@ -232,10 +223,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testWriteByteArraySliceWithOffsetGreaterThanLength() throws Exception { + public void testWriteByteArraySliceWithOffsetGreaterThanLength() { byte[] payload = "BLAH".getBytes(); try { @@ -295,10 +285,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testEnsureCapacityWithNegativeRequiredAvailability() throws Exception { + public void testEnsureCapacityWithNegativeRequiredAvailability() { assertEquals(MllpSocketBuffer.MIN_BUFFER_SIZE, instance.capacity()); instance.ensureCapacity(-1); @@ -309,10 +298,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testEnsureCapacityWithOutOfRangeRequiredAvailability() throws Exception { + public void testEnsureCapacityWithOutOfRangeRequiredAvailability() { assertEquals(MllpSocketBuffer.MIN_BUFFER_SIZE, instance.capacity()); try { @@ -347,10 +335,9 @@ public class MllpSocketBufferWriteTest extends SocketBufferTestSupport { /** * Description of test. * - * @throws Exception in the event of a test error. */ @Test - public void testEnsureCapacityWithAlreadyAllocateMaxBufferSize() throws Exception { + public void testEnsureCapacityWithAlreadyAllocateMaxBufferSize() { assertEquals(MllpSocketBuffer.MIN_BUFFER_SIZE, instance.capacity()); instance.ensureCapacity(MllpSocketBuffer.MAX_BUFFER_SIZE); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/test/executor/PooledExecutorTest.java b/components/camel-mllp/src/test/java/org/apache/camel/test/executor/PooledExecutorTest.java index 85526e63847..40c9898d69e 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/test/executor/PooledExecutorTest.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/test/executor/PooledExecutorTest.java @@ -30,12 +30,12 @@ public class PooledExecutorTest { TestExecutor instance; @BeforeEach - public void setUp() throws Exception { + public void setUp() { instance = new TestExecutor(THREAD_COUNT); } @AfterEach - public void tearDown() throws Exception { + public void tearDown() { instance.stop(); } diff --git a/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpClientResource.java b/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpClientResource.java index 9996fa19c98..e565d39861c 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpClientResource.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpClientResource.java @@ -80,14 +80,14 @@ public class MllpClientResource implements BeforeEachCallback, AfterEachCallback } @Override - public void beforeEach(ExtensionContext context) throws Exception { + public void beforeEach(ExtensionContext context) { if (0 < mllpPort) { this.connect(); } } @Override - public void afterEach(ExtensionContext context) throws Exception { + public void afterEach(ExtensionContext context) { this.close(); } @@ -313,7 +313,7 @@ public class MllpClientResource implements BeforeEachCallback, AfterEachCallback return receiveFramedData(soTimeout); } - public String receiveFramedData(int timout) throws SocketException, SocketTimeoutException { + public String receiveFramedData(int timout) throws SocketException { if (!isConnected()) { throw new MllpJUnitResourceException("Cannot receive acknowledgement - client is not connected"); } @@ -382,7 +382,7 @@ public class MllpClientResource implements BeforeEachCallback, AfterEachCallback return receiveData(soTimeout); } - public String receiveData(int timeout) throws SocketException, SocketTimeoutException { + public String receiveData(int timeout) throws SocketException { clientSocket.setSoTimeout(timeout); StringBuilder availableInput = new StringBuilder(); @@ -401,7 +401,7 @@ public class MllpClientResource implements BeforeEachCallback, AfterEachCallback return availableInput.toString(); } - public String eatData() throws SocketException, SocketTimeoutException { + public String eatData() throws SocketException { return eatData(soTimeout); } diff --git a/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java b/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java index c2444035470..363bb5d7740 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/test/junit/rule/mllp/MllpServerResource.java @@ -163,7 +163,7 @@ public class MllpServerResource implements BeforeEachCallback, AfterEachCallback } @Override - public void afterEach(ExtensionContext context) throws Exception { + public void afterEach(ExtensionContext context) { shutdown(); } diff --git a/components/camel-mllp/src/test/java/org/apache/camel/test/mllp/PassthroughProcessor.java b/components/camel-mllp/src/test/java/org/apache/camel/test/mllp/PassthroughProcessor.java index 5e3837174cc..bc4cf44fab0 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/test/mllp/PassthroughProcessor.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/test/mllp/PassthroughProcessor.java @@ -35,7 +35,7 @@ public class PassthroughProcessor implements Processor { } @Override - public void process(Exchange exchange) throws Exception { + public void process(Exchange exchange) { String message = exchange.getIn().getBody(String.class); if (null != message) { String msh = message.substring(0, message.indexOf('\r')); diff --git a/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketInputStreamStub.java b/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketInputStreamStub.java index bdad3c154e3..4526d1f1270 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketInputStreamStub.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketInputStreamStub.java @@ -114,7 +114,7 @@ public class SocketInputStreamStub extends InputStream { } @Override - public int available() throws IOException { + public int available() { if (packetQueue.size() > 0) { Object element = packetQueue.element(); if (element instanceof ByteArrayInputStream) { @@ -140,7 +140,7 @@ public class SocketInputStreamStub extends InputStream { return this; } - public SocketInputStreamStub addPacket(byte[] bytes) throws IOException { + public SocketInputStreamStub addPacket(byte[] bytes) { if (bytes != null) { this.packetQueue.add(new ByteArrayInputStream(bytes)); } else { @@ -160,7 +160,7 @@ public class SocketInputStreamStub extends InputStream { return this; } - public SocketInputStreamStub addPacket(String... strings) throws IOException { + public SocketInputStreamStub addPacket(String... strings) { this.packetQueue.add(new ByteArrayInputStream(PayloadBuilder.build(strings))); return this; diff --git a/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketStub.java b/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketStub.java index 9ae2f9acf3d..03cb74e3d99 100644 --- a/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketStub.java +++ b/components/camel-mllp/src/test/java/org/apache/camel/test/stub/tcp/SocketStub.java @@ -89,13 +89,13 @@ public class SocketStub extends Socket { } @Override - public void setSoLinger(boolean on, int linger) throws SocketException { + public void setSoLinger(boolean on, int linger) { this.linger = on; this.lingerTimeout = linger; } @Override - public int getSoLinger() throws SocketException { + public int getSoLinger() { if (linger) { return lingerTimeout; } @@ -148,32 +148,32 @@ public class SocketStub extends Socket { } @Override - public synchronized int getReceiveBufferSize() throws SocketException { + public synchronized int getReceiveBufferSize() { return receiveBufferSize; } @Override - public synchronized void setReceiveBufferSize(int size) throws SocketException { + public synchronized void setReceiveBufferSize(int size) { this.receiveBufferSize = size; } @Override - public synchronized int getSendBufferSize() throws SocketException { + public synchronized int getSendBufferSize() { return sendBufferSize; } @Override - public synchronized void setSendBufferSize(int size) throws SocketException { + public synchronized void setSendBufferSize(int size) { this.sendBufferSize = size; } @Override - public synchronized int getSoTimeout() throws SocketException { + public synchronized int getSoTimeout() { return timeout; } @Override - public synchronized void setSoTimeout(int timeout) throws SocketException { + public synchronized void setSoTimeout(int timeout) { this.timeout = timeout; }