oscerd commented on a change in pull request #132:
URL: https://github.com/apache/camel-karaf/pull/132#discussion_r837385031
##########
File path: platforms/karaf/features/src/main/resources/features.xml
##########
@@ -364,37 +364,78 @@
<bundle
dependency='true'>wrap:mvn:com.amazonaws/aws-xray-recorder-sdk-sql-mysql/${aws-xray-version}</bundle>
<bundle>mvn:org.apache.camel/camel-aws-xray/${project.version}</bundle>
</feature>
- <feature name='camel-azure-storage-blob' version='${project.version}'
start-level='50'>
- <feature version='${project.version}'>camel-core</feature>
+ <feature name='camel-azure-core' version='${camel.version}'
description='Core bundles for Azure usage.' start-level='50' hidden='true'>
+ <feature version='${camel.version}' dependency='true'>camel-core</feature>
+
<bundle
dependency='true'>mvn:com.fasterxml.jackson.core/jackson-core/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.core/jackson-databind/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.core/jackson-annotations/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.module/jackson-module-jaxb-annotations/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:org.codehaus.woodstox/stax2-api/${stax2v4-api-bundle-version}</bundle>
- <bundle
dependency='true'>mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${jackson2-version}</bundle>
+ <bundle
dependency='true'>mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${jackson.version}</bundle>
<bundle
dependency='true'>mvn:org.reactivestreams/reactive-streams/${reactive-streams-version}</bundle>
<bundle
dependency='true'>mvn:io.projectreactor/reactor-core/${reactor-version}</bundle>
<bundle
dependency='true'>mvn:commons-io/commons-io/${commons-io-version}</bundle>
<bundle
dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.azure-core/${azure-core-bundle-version}</bundle>
+ </feature>
+ <feature name='camel-azure-eventhubs' version='${project.version}'
start-level='50'>
+ <feature version='${project.version}'>camel-core</feature>
+ <feature version='${project.version}'
prerequisite='true'>camel-azure-core</feature>
+ <bundle
dependency='true'>mvn:org.apache.qpid/qpid-jms-client/${qpid-jms-client-version}</bundle>
+ <bundle
dependency='true'>mvn:org.apache.qpid/proton-j/${qpid-proton-j-version}</bundle>
+ <feature version='${project.version}'>camel-azure-storage-blob</feature>
+ <bundle
dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.azure-core-amqp/${azure-core-amqp-bundle-version}</bundle>
+ <bundle
dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.azure-messaging-eventhubs/${azure-messaging-eventhubs-bundle-version}</bundle>
+ <bundle
dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.azure-messaging-eventhubs-checkpointstore-blob/${azure-messaging-eventhubs-checkpointstore-blob-bundle-version}</bundle>
+
<bundle>mvn:org.apache.camel/camel-azure-eventhubs/${project.version}</bundle>
+ </feature>
+ <feature name='camel-azure-identity' version='${camel.version}'
description='Feature to use the Azure-Identity functionality.'>
Review comment:
There is no component named camel-azure-identity in Camel.
##########
File path: platforms/karaf/features/src/main/resources/features.xml
##########
@@ -364,37 +364,78 @@
<bundle
dependency='true'>wrap:mvn:com.amazonaws/aws-xray-recorder-sdk-sql-mysql/${aws-xray-version}</bundle>
<bundle>mvn:org.apache.camel/camel-aws-xray/${project.version}</bundle>
</feature>
- <feature name='camel-azure-storage-blob' version='${project.version}'
start-level='50'>
- <feature version='${project.version}'>camel-core</feature>
+ <feature name='camel-azure-core' version='${camel.version}'
description='Core bundles for Azure usage.' start-level='50' hidden='true'>
+ <feature version='${camel.version}' dependency='true'>camel-core</feature>
+
<bundle
dependency='true'>mvn:com.fasterxml.jackson.core/jackson-core/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.core/jackson-databind/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.core/jackson-annotations/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:com.fasterxml.jackson.module/jackson-module-jaxb-annotations/${jackson2-version}</bundle>
<bundle
dependency='true'>mvn:org.codehaus.woodstox/stax2-api/${stax2v4-api-bundle-version}</bundle>
- <bundle
dependency='true'>mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/${jackson2-version}</bundle>
Review comment:
Why? There is no jackson.version in parent/pom from camel-dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
