essobedo commented on a change in pull request #84:
URL: https://github.com/apache/camel-examples/pull/84#discussion_r829821614
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
Why do you need an activation if your goal is to enable it with its id?
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
Review comment:
I'm wondering if it is really needed to prefix it by camel? it sounds
like a pleonasm to me
##########
File path: examples/main-xml/pom.xml
##########
@@ -113,5 +113,21 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
+ <profile>
+ <id>camel.debug</id>
+ <activation>
+ <property>
+ <name>camel.debug</name>
+ <value>true</value>
Review comment:
If so, I believe that you need to document it too as we cannot assume
that the user will check the pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
