JiriOndrusek opened a new pull request #3609: URL: https://github.com/apache/camel-quarkus/pull/3609
fixes https://github.com/apache/camel-quarkus/issues/3579 replaces https://github.com/apache/camel-quarkus/pull/3602 I used `ConnectionProvider` to avoid configuration of the datasource in `quartz.properties` (thanks @jamesnetherton for suggestion) Go through `usage.adoc` and `limitations.adoc` to see changes introduced for the users. This PR fixes all the unfinished (or limited) features from https://github.com/apache/camel-quarkus/pull/3602 I had to keep postgresql with fixed port number, because port number has to be used in quartz.properties for one kind of configuration. Follow-up work: 1. This implementation requires c3p0 (which is not needed when quarku's quartz is used). Without this ependency, I'm getting `Discovered unresolved type during parsing: com.mchange.v2.c3p0.C3P0ProxyConnection`. I'll create a ticket to investigate a possible removal of c3p0. (c3p0 is called from `JobStoreSupport.storeTrigger`) 2. There is a substitution of `LoadingLoaderClassLoadHelper.loadClass` which is eeded for the native support. I'll create a ticket for quartz project and reminder ticket to remove the substitution once it is resolved on Quartz. There is no need to add a paragraph into migration guide. All that worked before works in the same way. The new introduced configuration (using `quarz.properties` + agroal DS) did not work before. Camel standard behavior is only fixed here. Do we need to mention a new featre of an old extension somewhere? (like changelog) <!-- Uncomment and fill this section if your PR is not trivial [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes. [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #. [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough. [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea. [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request. [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
