orpiske edited a comment on pull request #6937: URL: https://github.com/apache/camel/pull/6937#issuecomment-1037077022
> @orpiske ok no problem, let's wait for it. I converted it to draft, please let me know when it is done on your side. Thanks for understanding. > BTW could you please tell why you changed the type of event that triggers the build (from pull_request to push + pull_request_target)? It's part of my investigation with SonarCloud folks. Long story short: up to some time ago, their plugin would only work with `pull_request` events. However, events of this type of event [do not expose secrets](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request). This prevents us from accessing the `SONAR_TOKEN` secret so we can run automated code analysis on the PRs. It seems that SonarCloud client has introduced support for `pull_request_target` [events](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target). This type of event does allow access to the token we need and it should be able to run the analysis on the PR code, with all the expected features (comments, labels and whatnot). This is what I am working with them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
