ppalaga commented on issue #3503: URL: https://github.com/apache/camel-quarkus/issues/3503#issuecomment-1027791376
Thanks for the explanation @DenisIstomin, it is much clearer to me now! Step 1: I think giving users the option to set their own TrasformerFactory could awake the impression that any transformer factory implementation would work. In fact our extension expects this particular Xalan TrasformerFactory. So I'd be in favor of allowing end users to configure this factory via config params rather than passing their own class. Now how could we make the factory configurable. I'd vote for having a generic map of parameters, something like: ``` quarkus.camel.xalan.feature."http://javax.xml.XMLConstants/feature/secure-processing"; = true quarkus.camel.xalan.feature."http://xml.apache.org/xalan/features/optimize"; = true ``` They have something similar in Quarkus Agoal config https://github.com/quarkusio/quarkus/blob/main/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java#L138-L139 The defaults could be mainitained in a Map containing the current only feature `javax.xml.XMLConstants.FEATURE_SECURE_PROCESSING, true` Step 2.: I do not think we need something special only for the reflection registration. Given that those functions will mostly be provided by end users themselves, can't they simply add `@io.quarkus.runtime.annotations.RegisterForReflection` to the classes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
