djencks opened a new pull request #2951: URL: https://github.com/apache/camel-k/pull/2951
(on top of https://github.com/apache/camel-k/pull/2899) I think the relationship between camel-k (v1) and kamelets (v1alpha1) should be minimized. Currently there are 5 uses of v1 types in v1alpha1: RawMessage. This is, IMO, silly, since there's a v1alpha1 RawMessage. Using it everywhere in v1alpha1 is easy and doesn't appear to cause any problems. Template. This type is used only in v1alpha1 and causes no problems when moved there. Flow. This is deprecated in favor of Template. I suggest we remove it or set a date to remove it. It appears to be easy to copy a flow to a template. The other two may not be appropriate to copy to v1alpha1, I don't understand how this is used well enough to have an opinion: IntegrationSpec is used in KameletBindingSpec, as an optional member. Does it have the same meaning here as when used in camel-k? SourceSpec is used in KameletSpec. Does it have the same meaning here as when used in camel-k? At the moment this PR deals with the first three uses: - only use v1alpha1.RawMessage in v1alpha1 - move Template to v1alpha1 - copy Flow, when found, to a Template. Locally, running the make commands mentioned in releasing.adoc succeed and don't cause further changes. We'll see what happens with tests run from the PR.... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
