bvfalcon opened a new pull request #6808:
URL: https://github.com/apache/camel/pull/6808


   As logical continue of CAMEL-17476, changes in camel-google-mail were copied 
to components camel-google-calendar, camel-google-sheets, camel-google-drive.
   For each component 3 new parameters was added, specific for Google service 
account authorization: keyResource (JSON-formatted key-file with credentials), 
scopes (collection of component-specific Google Scopes) and delegate 
(domain-wide delegation). Parameters and methods of their processing are 
unified between all components. In some cases this unification makes necessary 
changes in DSL:
   1) Scopes in camel-google-drive.
   Before my changes scopes were initialized with [non-modifiable 
implementation of 
List](https://github.com/apache/camel/blob/main/components/camel-google/camel-google-drive/src/main/java/org/apache/camel/component/google/drive/GoogleDriveConfiguration.java#L47).
 It makes impossible to add additional scopes in DSL. Now scopes are not 
initialized by default and scopes definition must be defined in DSL as 
"&scopes[]=".
   2) Scopes in camel-google-calendar.
   Before my changes scopes were [defined as 
String](https://github.com/apache/camel/blob/main/components/camel-google/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/GoogleCalendarConfiguration.java#L41)
 and [parsed programmatically into 
List](https://github.com/apache/camel/blob/main/components/camel-google/camel-google-calendar/src/main/java/org/apache/camel/component/google/calendar/GoogleCalendarComponent.java#L58).
 Now scopes are defined as List and in DSL parameter "scopes" must be defined 
as "&scopes[]=" instead of "&scopes="
   
   **Important notice** about [Jakarta Activation in 
camel-google-mail](https://github.com/apache/camel/blob/main/components/camel-google/camel-google-mail/pom.xml#L106):
 since JDK 9 this module is not a part of JDK, so i remove this exclusion. As 
for as I know, [Apache Camel 3.x is oriented on Java 
11](https://camel.apache.org/blog/2019/12/Camel3-Whatsnew/#3-java-11). If this 
is not so, this exclusion must be parametrized with maven profiles or any 
similar way.
   
   P.S. Big thanks to @jamesnetherton for [upgrading google 
dependencies](https://github.com/apache/camel/pull/6799/). In such big project 
as Apache Camel different library versions can jar-hell provoke. Of course, it 
is unacceptable to leave different versions in such similar components.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to