orpiske commented on a change in pull request #6634:
URL: https://github.com/apache/camel/pull/6634#discussion_r778675634



##########
File path: core/camel-management-api/pom.xml
##########
@@ -242,42 +249,5 @@
                 </dependency>
             </dependencies>
         </profile>
-
-        <profile>
-            <id>jdk9s-build</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <dependencies>
-                <!-- xmltokenizer using woodstox -->
-                <dependency>
-                    <groupId>org.codehaus.woodstox</groupId>
-                    <artifactId>woodstox-core-asl</artifactId>
-                    <scope>test</scope>
-                </dependency>
-            </dependencies>
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <!-- skip file stress tests as they are intended 
to run manually -->
-                            <excludes>
-                                
<exclude>org/apache/camel/component/file/stress/**.java</exclude>
-                                
<exclude>**/DistributedCompletionIntervalTest.java</exclude>
-                                
<exclude>**/DistributedConcurrentPerCorrelationKeyTest.java</exclude>
-                                <exclude>${platform.skip.tests}</exclude>
-                            </excludes>
-                            
<forkedProcessTimeoutInSeconds>3000</forkedProcessTimeoutInSeconds>
-                            <!-- needed for testing the properties component 
-->
-                            <environmentVariables>
-                                <FOO_SERVICE_HOST>myserver</FOO_SERVICE_HOST>

Review comment:
       We should be fine, `core/camel-core-engine` does not have any tests in 
itself. The tests are in the `core/camel-core`  module which already define 
them.

##########
File path: core/camel-management-api/pom.xml
##########
@@ -242,42 +249,5 @@
                 </dependency>
             </dependencies>
         </profile>
-
-        <profile>
-            <id>jdk9s-build</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <dependencies>
-                <!-- xmltokenizer using woodstox -->
-                <dependency>
-                    <groupId>org.codehaus.woodstox</groupId>
-                    <artifactId>woodstox-core-asl</artifactId>
-                    <scope>test</scope>
-                </dependency>
-            </dependencies>
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <!-- skip file stress tests as they are intended 
to run manually -->
-                            <excludes>
-                                
<exclude>org/apache/camel/component/file/stress/**.java</exclude>
-                                
<exclude>**/DistributedCompletionIntervalTest.java</exclude>
-                                
<exclude>**/DistributedConcurrentPerCorrelationKeyTest.java</exclude>
-                                <exclude>${platform.skip.tests}</exclude>
-                            </excludes>
-                            
<forkedProcessTimeoutInSeconds>3000</forkedProcessTimeoutInSeconds>
-                            <!-- needed for testing the properties component 
-->
-                            <environmentVariables>
-                                <FOO_SERVICE_HOST>myserver</FOO_SERVICE_HOST>

Review comment:
       We should be fine, `core/camel-core-engine` does not have any tests in 
itself. The tests are in the `core/camel-core`  module which already define 
these variables.

##########
File path: core/camel-core-engine/pom.xml
##########
@@ -349,43 +357,6 @@
                 </dependency>
             </dependencies>
         </profile>
-
-        <profile>
-            <id>jdk9s-build</id>
-            <activation>
-                <jdk>[9,)</jdk>
-            </activation>
-            <dependencies>
-                <!-- xmltokenizer using woodstox -->
-                <dependency>
-                    <groupId>org.codehaus.woodstox</groupId>
-                    <artifactId>woodstox-core-asl</artifactId>
-                    <scope>test</scope>
-                </dependency>
-            </dependencies>
-            <build>
-                <plugins>
-                    <plugin>
-                        <artifactId>maven-surefire-plugin</artifactId>
-                        <configuration>
-                            <!-- skip file stress tests as they are intended 
to run manually -->
-                            <excludes>
-                                
<exclude>org/apache/camel/component/file/stress/**.java</exclude>
-                                
<exclude>**/DistributedCompletionIntervalTest.java</exclude>
-                                
<exclude>**/DistributedConcurrentPerCorrelationKeyTest.java</exclude>
-                                <exclude>${platform.skip.tests}</exclude>
-                            </excludes>
-                            
<forkedProcessTimeoutInSeconds>3000</forkedProcessTimeoutInSeconds>
-                            <!-- needed for testing the properties component 
-->
-                            <environmentVariables>
-                                <FOO_SERVICE_HOST>myserver</FOO_SERVICE_HOST>

Review comment:
       We should be fine, `core/camel-core-engine` does not have any tests in 
itself. The tests are in the `core/camel-core`  module which already define 
these variables.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to