astefanutti commented on a change in pull request #2771: URL: https://github.com/apache/camel-k/pull/2771#discussion_r777990928
########## File path: pkg/trait/mount.go ########## @@ -0,0 +1,177 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package trait + +import ( + "fmt" + "strings" + + appsv1 "k8s.io/api/apps/v1" + "k8s.io/api/batch/v1beta1" + corev1 "k8s.io/api/core/v1" + + serving "knative.dev/serving/pkg/apis/serving/v1" + + v1 "github.com/apache/camel-k/pkg/apis/camel/v1" + "github.com/apache/camel-k/pkg/util/kubernetes" + utilResource "github.com/apache/camel-k/pkg/util/resource" +) + +// The Mount trait can be used to configure volumes mounted on the Integration Pod. +// +// +camel-k:trait=mount +// nolint: tagliatelle +type mountTrait struct { + BaseTrait `property:",squash"` + // A list of configuration pointing to configmap/secret. Syntax: [configmap|secret]:name[key], where name represents the resource name and key optionally represents the resource key to be filtered + Configs []string `property:"configs" json:"configs,omitempty"` Review comment: The comment now documents what kind of content can be provided. I could still imagine an external user asking what's the difference between configs and resources functionally. May I suggest to add that configs are added to the classpath, and that they are typically used to configure Camel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
