djencks commented on pull request #630:
URL: https://github.com/apache/camel-kamelets/pull/630#issuecomment-999010591


   I’ll try to finish this up…. the new stuff has Antora extract the image from 
the yml, IIRC the generator is not needed at all.
   
   > On Dec 21, 2021, at 2:01 AM, Nicola Ferraro ***@***.***> wrote:
   > 
   > 
   > Yes, at the moment both original and new versions of the kamelets pages 
are shown for easier comparison. One difference is that I changed how the 
"required" status of a property is shown to match the other tables I've worked 
on: instead of a star after the name, the description starts with at bold 
"Required".
   > 
   > Yes, the generator puts images into assets/images/kamelets, so I think 
this line needs to be changed: 
https://github.com/apache/camel-kamelets/blob/381fb8b16e6981203e6bcc329a47793f9b86906e/script/generator/generator.go#L360
 
<https://github.com/apache/camel-kamelets/blob/381fb8b16e6981203e6bcc329a47793f9b86906e/script/generator/generator.go#L360>
   > —
   > Reply to this email directly, view it on GitHub 
<https://github.com/apache/camel-kamelets/pull/630#issuecomment-998638407>, or 
unsubscribe 
<https://github.com/notifications/unsubscribe-auth/AAELDXRSSQE62GRZOBIYXOLUSBF7RANCNFSM5KCPNZUQ>.
   > You are receiving this because you authored the thread.
   > 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to