ppalaga commented on a change in pull request #3359:
URL: https://github.com/apache/camel-quarkus/pull/3359#discussion_r764344277



##########
File path: integration-tests/avro/pom.xml
##########
@@ -62,6 +62,7 @@
             <plugin>
                 <groupId>io.quarkus</groupId>
                 <artifactId>quarkus-maven-plugin</artifactId>
+                <extensions>true</extensions><!-- Workaround for 
https://github.com/quarkusio/quarkus/issues/21718 -->

Review comment:
       > What is the default version of extensions ? 
   
   `false`
   
   > Why we don't have a value for it ?
   
   `true` is only needed if a plugin should act as Maven extension - i.e. have 
access to more Maven APIs than usual plugins.
   Here I am trying to eliminate the failure of second `mvnd` invocation, that 
happens only with projects where we invoke `quarkus-maven-plugin` 's 
`generate-code` goal. Without `<extensions>true</extensions>` some cache inside 
`quarkus-maven-plugin` does not get cleared via 
`AbstractMavenLifecycleParticipant`, because 
`AbstractMavenLifecycleParticipant` are only honored in Maven extensions.
   
   This helps to get rid of the failure, but it is still a good question 
whether the plugin works correctly in the rest of the test modules (even though 
it does not fail there). 
   
   WDYT @aloubyansky do we need to have `<extensions>true</extensions>` also in 
test modules where second mvnd invocation does not fail? - i.e. does the 
`build` mojo assume/require a fresh bootstrap on every maven invocation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to