ffang commented on pull request #3341: URL: https://github.com/apache/camel-quarkus/pull/3341#issuecomment-985621648
> About where to put `<argLine>--add-opens java.base/java.net=ALL-UNNAMED</argLine>` given that java 11 is our baseline, where this should work and given that we need it for both plugins in all profiles, can't we just add > > ``` > <properties> > <!-- This is to allow the nasty things we do in KuduInfrastructureTestHelper --> > <argLine>--add-opens java.base/java.net=ALL-UNNAMED</argLine> > </properties> > ``` > > in the top profile-less context (and remove the old `jdk16-workarounds` profile altogether)? Hi @ppalaga , I may miss your point, but if we add ``` </dependencies> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-surefire-plugin</artifactId> + <configuration> + <!-- This is to allow the "deep reflection" we do in KuduInfrastructureTestHelper --> + <argLine>--add-opens java.base/java.net=ALL-UNNAMED</argLine> + </configuration> + </plugin> + </plugins> + </build> ``` in the pom.xml out of profiles, this can't affect the maven-failsafe-plugin configuration in native profile. The maven-failsafe-plugin configuration in native profile can't pick up this argLine and will fail with JDK17 in native mode. We need to add this argLine in native profile anyway. Freeman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
