PascalSchumacher commented on a change in pull request #5787:
URL: https://github.com/apache/camel/pull/5787#discussion_r742663941
##########
File path:
core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/StaxConverter.java
##########
@@ -316,7 +319,10 @@ private XMLOutputFactory getXMLOutputFactory() {
private void returnXMLOutputFactory(XMLOutputFactory factory) {
if (factory != outputFactory) {
- OUTPUT_FACTORY_POOL.offer(factory);
+ boolean resultOfOffer = OUTPUT_FACTORY_POOL.offer(factory);
+ if (!resultOfOffer) {
+ LOG.error("factory wasn't added into OUTPUT_FACTORY_POOL");
Review comment:
The static analyis tool found that a return value is ignored. This can
of be a problem, but the static analysis tool does not know the context of it
happening. If this was logged at debug or info level it would be the same for
the static analyisis tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
