zbendhiba commented on a change in pull request #3170:
URL: https://github.com/apache/camel-quarkus/pull/3170#discussion_r725006225
##########
File path:
integration-test-groups/aws2/aws2-sqs-sns/src/test/java/org/apache/camel/quarkus/component/aws2/sqs/it/Aws2SqsSnsTest.java
##########
@@ -43,6 +49,31 @@
@QuarkusTestResource(Aws2TestResource.class)
class Aws2SqsSnsTest {
+ @AfterEach
+ public void purgeQueueAndWait() {
+ String qName = getPredefinedQueueName();
+ purgeQueue(qName);
+ // purge takes up to 60 seconds
+ // all messages delivered within those 60 seconds might get deleted
+ try {
Review comment:
@VratislavHais my point is that you have a TimeUnit.SECONDS.sleep(60);
+ the await
was asking if it would be better to use just the await ?
##########
File path:
integration-test-groups/aws2/aws2-sqs-sns/src/test/java/org/apache/camel/quarkus/component/aws2/sqs/it/Aws2SqsSnsTest.java
##########
@@ -65,10 +96,12 @@ public void sqs() {
@Test
public void sqsDeleteMessage() {
final String qName = getPredefinedQueueName();
- final String msg = sendSingleMessageToQueue(qName);
+ sendSingleMessageToQueue(qName);
final String receipt = receiveReceiptOfMessageFromQueue(qName);
+ final String msg = sendSingleMessageToQueue(qName);
deleteMessageFromQueue(qName, receipt);
- Assertions.assertNotEquals(receiveMessageFromQueue(qName), msg);
+ awaitMessageWithExpectedContentFromQueue(msg, qName);
Review comment:
@VratislavHais that's clear now. Maybe just put a meaningful comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
