davsclaus commented on a change in pull request #6191:
URL: https://github.com/apache/camel/pull/6191#discussion_r720206476
##########
File path:
core/camel-support/src/main/java/org/apache/camel/support/EventHelper.java
##########
@@ -44,6 +44,7 @@
// be left as-is.
private static final Logger LOG =
LoggerFactory.getLogger(EventHelper.class);
+ private static volatile boolean started = true;
Review comment:
should be false by default
##########
File path:
core/camel-support/src/main/java/org/apache/camel/support/EventHelper.java
##########
@@ -1300,7 +1301,7 @@ public static boolean notifyStepFailed(CamelContext
context, Exchange exchange,
private static boolean doNotifyEvent(EventNotifier notifier, CamelEvent
event) {
// only notify if notifier is started
- boolean started = true;
+ started = true;
if (notifier instanceof StatefulService) {
Review comment:
if (!started && notifier ....)
##########
File path:
core/camel-support/src/main/java/org/apache/camel/support/EventHelper.java
##########
@@ -1300,7 +1301,7 @@ public static boolean notifyStepFailed(CamelContext
context, Exchange exchange,
private static boolean doNotifyEvent(EventNotifier notifier, CamelEvent
event) {
// only notify if notifier is started
- boolean started = true;
+ started = true;
Review comment:
remove started = true as we need to check the notifier instance.
And if its NOT a stateful service then we can regard it as started
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
