lburgazzoli commented on a change in pull request #2662:
URL: https://github.com/apache/camel-k/pull/2662#discussion_r717595519



##########
File path: pkg/apis/camel/v1/integration_types.go
##########
@@ -184,12 +184,10 @@ const (
        IntegrationConditionProbesAvailableReason string = "ProbesAvailable"
        // IntegrationConditionErrorReason --
        IntegrationConditionErrorReason string = "Error"
-       // IntegrationConditionCronJobCreatedReason --
-       IntegrationConditionCronJobCreatedReason string = "CronJobCreated"
-       // IntegrationConditionReplicaSetReadyReason --
-       IntegrationConditionReplicaSetReadyReason string = "ReplicaSetReady"
-       // IntegrationConditionReplicaSetNotReadyReason --
-       IntegrationConditionReplicaSetNotReadyReason string = 
"ReplicaSetNotReady"
+       // IntegrationConditionPodsReadyReason --
+       IntegrationConditionPodsReadyReason string = "PodsReady"
+       // IntegrationConditionPodsNotReadyReason --
+       IntegrationConditionPodsNotReadyReason string = "PodsNotReady"

Review comment:
       Should we take this as a potential minor breaking change ? i.e. for 
tools that are monitoring an integration, changing a condition could break them.
   
   I don't have any objection but maybe we need to document it 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to