ppalaga commented on a change in pull request #3116: URL: https://github.com/apache/camel-quarkus/pull/3116#discussion_r713691600
########## File path: extensions/aws2-ddb/runtime/src/doc/limitations.adoc ########## @@ -0,0 +1,3 @@ +Feature `Batch consumer` (see https://camel.apache.org/components/latest/aws2-ddbstream-component.html#_batch_consumer[documentation]) +is not available in quarkus aws2-ddb extension because of the issue +https://issues.apache.org/jira/browse/CAMEL-16837[CAMEL-16837]. Review comment: ```suggestion The https://camel.apache.org/components/latest/aws2-ddbstream-component.html#_batch_consumer[batch consumer] feature is not available in Camel Quarkus AWS2 DynamoDB extension because of https://issues.apache.org/jira/browse/CAMEL-16837[CAMEL-16837]. ``` ########## File path: extensions/aws2-ddb/runtime/src/doc/configuration.adoc ########## @@ -0,0 +1,50 @@ +The aws2-ddb extension is using a DynamoDB client under the hood. +The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamobdb`. + +=== Client created by this extension + +In that case fill following properties: + + +[source,properties] +---- +camel.component.aws2-ddb.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddb.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddb.region=${AWS_REGION:us-east-1} +---- + +or + +[source,properties] +---- +camel.component.aws2-ddbstream.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddbstream.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddbstream.region=${AWS_REGION:us-east-1} +---- + +=== Client created by `quarkus-amazon-dynamodb` + +To use client created by `quarkus-amazon-dynamodb` extension, follow the https://quarkus.io/guides/amazon-dynamodb#configuring-dynamodb-clients[documentation] with some restrictions: Review comment: ```suggestion To use the client created by `quarkus-amazon-dynamodb` extension, follow the https://quarkus.io/guides/amazon-dynamodb#configuring-dynamodb-clients[documentation] with some restrictions: ``` ########## File path: extensions/aws2-ddb/runtime/src/doc/configuration.adoc ########## @@ -0,0 +1,50 @@ +The aws2-ddb extension is using a DynamoDB client under the hood. +The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamobdb`. Review comment: ```suggestion The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamodb` from Quarkus project. ``` ########## File path: extensions/aws2-ddb/runtime/src/doc/configuration.adoc ########## @@ -0,0 +1,50 @@ +The aws2-ddb extension is using a DynamoDB client under the hood. +The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamobdb`. + +=== Client created by this extension + +In that case fill following properties: + + +[source,properties] +---- +camel.component.aws2-ddb.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddb.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddb.region=${AWS_REGION:us-east-1} +---- + +or + +[source,properties] +---- +camel.component.aws2-ddbstream.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddbstream.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddbstream.region=${AWS_REGION:us-east-1} +---- + +=== Client created by `quarkus-amazon-dynamodb` + +To use client created by `quarkus-amazon-dynamodb` extension, follow the https://quarkus.io/guides/amazon-dynamodb#configuring-dynamodb-clients[documentation] with some restrictions: + +- Apache client type has to be selected +[source,properties] +---- +quarkus.dynamodb.sync-client.type=apache +---- + Review comment: ```suggestion + ``` ########## File path: extensions/aws2-ddb/runtime/src/doc/configuration.adoc ########## @@ -0,0 +1,50 @@ +The aws2-ddb extension is using a DynamoDB client under the hood. +The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamobdb`. + +=== Client created by this extension + +In that case fill following properties: + + +[source,properties] +---- +camel.component.aws2-ddb.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddb.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddb.region=${AWS_REGION:us-east-1} +---- + +or + +[source,properties] +---- +camel.component.aws2-ddbstream.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddbstream.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddbstream.region=${AWS_REGION:us-east-1} +---- + +=== Client created by `quarkus-amazon-dynamodb` + +To use client created by `quarkus-amazon-dynamodb` extension, follow the https://quarkus.io/guides/amazon-dynamodb#configuring-dynamodb-clients[documentation] with some restrictions: + +- Apache client type has to be selected Review comment: ```suggestion - Apache client type has to be selected + ``` A single `+` sign on a line makes following code block belong to the previous list item ########## File path: extensions/aws2-ddb/runtime/src/doc/configuration.adoc ########## @@ -0,0 +1,50 @@ +The aws2-ddb extension is using a DynamoDB client under the hood. +The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamobdb`. + +=== Client created by this extension + +In that case fill following properties: + + +[source,properties] +---- +camel.component.aws2-ddb.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddb.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddb.region=${AWS_REGION:us-east-1} +---- + +or + +[source,properties] +---- +camel.component.aws2-ddbstream.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddbstream.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddbstream.region=${AWS_REGION:us-east-1} +---- + +=== Client created by `quarkus-amazon-dynamodb` Review comment: ```suggestion === Client created by `quarkus-amazon-dynamodb` extension ``` ########## File path: extensions/aws2-ddb/runtime/src/doc/configuration.adoc ########## @@ -0,0 +1,50 @@ +The aws2-ddb extension is using a DynamoDB client under the hood. +The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamobdb`. + +=== Client created by this extension + +In that case fill following properties: + + +[source,properties] +---- +camel.component.aws2-ddb.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddb.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddb.region=${AWS_REGION:us-east-1} +---- + +or + +[source,properties] +---- +camel.component.aws2-ddbstream.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddbstream.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddbstream.region=${AWS_REGION:us-east-1} +---- + +=== Client created by `quarkus-amazon-dynamodb` + +To use client created by `quarkus-amazon-dynamodb` extension, follow the https://quarkus.io/guides/amazon-dynamodb#configuring-dynamodb-clients[documentation] with some restrictions: + +- Apache client type has to be selected +[source,properties] +---- +quarkus.dynamodb.sync-client.type=apache +---- + +- All required dependencies are already part of the extension. +There is no need to add them. + Review comment: ```suggestion ``` ########## File path: extensions/aws2-ddb/runtime/src/doc/configuration.adoc ########## @@ -0,0 +1,50 @@ +The aws2-ddb extension is using a DynamoDB client under the hood. +The underlying DynamoDB client could either be created by this extension itself or by the `quarkus-amazon-dynamobdb`. + +=== Client created by this extension + +In that case fill following properties: + + +[source,properties] +---- +camel.component.aws2-ddb.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddb.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddb.region=${AWS_REGION:us-east-1} +---- + +or + +[source,properties] +---- +camel.component.aws2-ddbstream.access-key=${AWS_ACCESS_KEY} +camel.component.aws2-ddbstream.secret-key=${AWS_SECRET_KEY} +camel.component.aws2-ddbstream.region=${AWS_REGION:us-east-1} +---- + +=== Client created by `quarkus-amazon-dynamodb` + +To use client created by `quarkus-amazon-dynamodb` extension, follow the https://quarkus.io/guides/amazon-dynamodb#configuring-dynamodb-clients[documentation] with some restrictions: + +- Apache client type has to be selected +[source,properties] +---- +quarkus.dynamodb.sync-client.type=apache +---- + +- All required dependencies are already part of the extension. +There is no need to add them. Review comment: It looks like the opposite is true, isn't it? ```suggestion - You need to add the `io.quarkus:quarkus-amazon-dynamodb` to your application. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
