astefanutti commented on a change in pull request #2646: URL: https://github.com/apache/camel-k/pull/2646#discussion_r713054353
########## File path: pkg/util/label/label.go ########## @@ -0,0 +1,44 @@ +/* +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package label + +import ( + "fmt" + "strings" + + v1 "github.com/apache/camel-k/pkg/apis/camel/v1" + "k8s.io/apimachinery/pkg/labels" +) + +// The AdditionalLabels is a big string consisting of key=value, set at build time +// when set are to be added to Deployments, CronJob and KNativeService whose pods +// should expose these labels + +// AdditionalLabels are labels=values, they MUST be set as key=value separated by comma , +// example: myKey1=myValue1,myKey2=myValue2 +// Also it supports replacing a value for the integration name, just put @ around it +// example: myKey1=myValue1,myKey2=@integration@ +var AdditionalLabels = "" + +// parses the AdditionalLabels variable and returns as map[string]string +func AddLabels(integration string) map[string]string { + AdditionalLabels = strings.ReplaceAll(AdditionalLabels, "@integration@", integration) + AdditionalLabels = fmt.Sprintf("%s=%s,%s", v1.IntegrationLabel, integration, AdditionalLabels) + lbls, _ := labels.ConvertSelectorToLabelsMap(AdditionalLabels) Review comment: I think I've just experienced why fail-fast error handing is generally preferred. I tried to understand why the tests were failing, and it took me half an hour, scratching my head, to realise that there was a trailing comma in the string, among the zillion log statements printed in the e2e test suite execution, like the needle in a haystack. We are lucky Kubernetes caught the error, but that's the kind of things that could be hard to detect, and panicking would make it immediate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
