zregvart commented on pull request #6096: URL: https://github.com/apache/camel/pull/6096#issuecomment-920797251
> LGTM. I believe the bindy problem can be fixed by changing UpdateReadmeMojo line 511 to > > ``` > String shortName = "mail".equals(name) ? "imap" : "bindy".equals(name) ? "bindy-csv" : name; > ``` Seems that there are more than one bindy-*.json files, and I guess we want to include all of them: ``` ./components/camel-bindy/src/generated/resources/org/apache/camel/dataformat/bindy/csv/bindy-csv.json ./components/camel-bindy/src/generated/resources/org/apache/camel/dataformat/bindy/fixed/bindy-fixed.json ./components/camel-bindy/src/generated/resources/org/apache/camel/dataformat/bindy/kvp/bindy-kvp.json ``` I was thinking either creating three .adoc files for bindy based on the curent single one, or to invoke the jsonPathTable macro three times, which I think will be a bit simpler. I'm trying the latter approach now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
