djencks commented on pull request #6040: URL: https://github.com/apache/camel/pull/6040#issuecomment-920297066
Your PR looks good to me, I made a suggestion about the bindy problem. I think that the jasonpath extension will produce a warning if there’s no json file, it certainly should. I’ve been revamping the extension locally to among other things improve logging, so it’s possible this is only happening with my uncommitted changes. I see that there are a lot of other attribute names that aren’t lower-case, so after this current PR is merged I’d like to make a new PR that lower-cases all the AsciiDoc attribute names. David Jencks > On Sep 15, 2021, at 1:47 AM, Zoran Regvart ***@***.***> wrote: > > > I would still like to split the changes in this PR into independent change sets. I see two changes here: > > use of partials with jsonpathTable2 macro > attribute rename (docTitle -> doctitle) > There is also a change image paths that we already merged, and this is conflicting right now. > > I'm working on incorporation of the first change, to use the jsonpathTable2 macro and I'm nearly there. I wanted to double check that every .adoc file has a corresponding .json file with the Camel metadata. I'm a bit spotty with time right now, but this is something I would like to get done today/tomorrow. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/camel/pull/6040#issuecomment-919824063>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELDXTCLWLVGUWJ2HT73B3UCBMQVANCNFSM5DLBEWFQ>. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
