Author: davsclaus
Date: Mon Jul 16 07:06:02 2012
New Revision: 1361920
URL: http://svn.apache.org/viewvc?rev=1361920&view=rev
Log:
CAMEL-5444: Log a WARN if shared reply queues are in use as they are slow, to
make this stand out to the Camel end users, so they know about this and can
reconfigured for a better solution if that is possible for their use-case.
Modified:
camel/branches/camel-2.10.x/ (props changed)
camel/branches/camel-2.10.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
Propchange: camel/branches/camel-2.10.x/
------------------------------------------------------------------------------
Merged /camel/trunk:r1361919
Propchange: camel/branches/camel-2.10.x/
------------------------------------------------------------------------------
--- svnmerge-integrated (original)
+++ svnmerge-integrated Mon Jul 16 07:06:02 2012
@@ -1 +1 @@
-/camel/trunk:1-1358964,1359013,1359197,1359226,1359265,1359341,1359383,1360031,1360241,1360339,1360525-1360527,1360581,1360583,1360719,1361116-1361117,1361477
+/camel/trunk:1-1358964,1359013,1359197,1359226,1359265,1359341,1359383,1360031,1360241,1360339,1360525-1360527,1360581,1360583,1360719,1361116-1361117,1361477,1361919
Modified:
camel/branches/camel-2.10.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
URL:
http://svn.apache.org/viewvc/camel/branches/camel-2.10.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java?rev=1361920&r1=1361919&r2=1361920&view=diff
==============================================================================
---
camel/branches/camel-2.10.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
(original)
+++
camel/branches/camel-2.10.x/components/camel-jms/src/main/java/org/apache/camel/component/jms/reply/PersistentQueueReplyManager.java
Mon Jul 16 07:06:02 2012
@@ -145,6 +145,9 @@ public class PersistentQueueReplyManager
answer.setCacheLevel(DefaultMessageListenerContainer.CACHE_SESSION);
log.debug("Using shared queue: " + endpoint.getReplyTo() + "
with dynamic message selector as reply listener: " + answer);
}
+ // shared is not as fast as temporary or exclusive, so log this so
the end user may be aware of this
+ log.warn("{} is using a shared reply queue, which is not as fast
as alternatives."
+ + " See more detail at the section 'Request-reply over
JMS' at http://camel.apache.org/jms";, endpoint);
} else if (ReplyToType.Exclusive == type) {
answer = new ExclusivePersistentQueueMessageListenerContainer();
// must use cache level consumer for exclusive as there is no
message selector
