aldettinger commented on a change in pull request #3066: URL: https://github.com/apache/camel-quarkus/pull/3066#discussion_r702709711
########## File path: integration-tests/sql/pom.xml ########## @@ -143,6 +139,125 @@ </plugins> </build> </profile> + <profile> + <id>h2</id> + <activation> + <activeByDefault>true</activeByDefault> + <property> + <name>!SQL_JDBC_DB_KIND</name> + </property> + </activation> + <dependencies> + <dependency> + <groupId>io.quarkus</groupId> + <artifactId>quarkus-jdbc-h2</artifactId> + </dependency> + </dependencies> + </profile> + <profile> + <id>postgresql</id> + <activation> + <property> + <name>SQL_JDBC_DB_KIND</name> + <value>postgresql</value> + </property> + </activation> + <dependencies> + <dependency> + <groupId>io.quarkus</groupId> + <artifactId>quarkus-jdbc-postgresql</artifactId> Review comment: I wonder if some thing like quarkus-jdbc-${SQL_JDBC_DB_KIND} could be used. It would be less lines in the pom file and maybe even fail when a wrong value is provided. I'm just curious, it's not blocking at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org