astefanutti commented on a change in pull request #2577:
URL: https://github.com/apache/camel-k/pull/2577#discussion_r701888927
##########
File path: deploy/traits.yaml
##########
@@ -833,19 +842,39 @@ traits:
- name: tls-termination
type: string
description: The TLS termination type, like `edge`, `passthrough` or
`reencrypt`.Refer
- to the OpenShift documentation for additional information.
+ to the OpenShift route documentation for additional information.
- name: tls-certificate
type: string
- description: The TLS certificate contents.Refer to the OpenShift
documentation
+ description: The TLS certificate contents.Refer to the OpenShift route
documentation
for additional information.
+ - name: tls-certificate-secret
+ type: string
+ description: The TLS certificate contents read from a secret. The format
is "secret-name[/key-name]",
Review comment:
The way it is put, we may understand that the property must be the
content of the TLS certificate, while it must be the secret containing the
certificate. I find the later a lot more descriptive as to what is expected for
the end user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
