VratislavHais commented on a change in pull request #3052:
URL: https://github.com/apache/camel-quarkus/pull/3052#discussion_r699169358
##########
File path:
integration-tests/rest/src/test/java/org/apache/camel/quarkus/component/rest/it/RestTest.java
##########
@@ -25,9 +25,11 @@
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.matchesPattern;
+import static org.junit.jupiter.api.Assertions.assertEquals;
@QuarkusTest
class RestTest {
+ private static final Person person = new Person("John", "Doe", 64);
Review comment:
it's definitely not a requirement. I just thought it would be a little
better to create the object only once. I'll change it as you suggest.
##########
File path:
integration-tests/rest/src/main/java/org/apache/camel/quarkus/component/rest/it/RestResource.java
##########
@@ -68,4 +68,26 @@ public String restProducer(@QueryParam("port") int port) {
return producerTemplate.requestBodyAndHeaders(
"rest:get:/rest/template/{messageStart}/{messageEnd}?host=localhost:" + port,
null, headers, String.class);
}
+
+ @Path("/producer/binding/mode/json")
+ @GET
+ @Produces(MediaType.APPLICATION_JSON)
+ public Person restProducerBindingModeJson(@QueryParam("port") int port) {
+ String query = "rest:get:/rest/binding/json/producer" +
+ "?bindingMode=json" +
+ "&outType=org.apache.camel.quarkus.component.rest.it.Person" +
+ "&host=localhost:" + port;
Review comment:
Hello @ppalaga,
the above two test only Consumer while addition in this PR covers Producer.
As you can see within this test coverage result
https://fuse-next-jenkins-csb-fuse-qe.apps.ocp4.prod.psi.redhat.com/job/Integration.next/job/camel-quarkus/job/code-coverage/43/Camel_20JaCoCo_20report/org.apache.camel.component.rest/RestProducer.java.html#L272
method `createBindingProcessor()` is almost entirely untested. With those
changes the coverage increase greatly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@camel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
